You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/12/16 21:17:57 UTC

[GitHub] [helix] brentwritescode commented on a change in pull request #1594: Fix builds failing on some non-Oracle JDKs

brentwritescode commented on a change in pull request #1594:
URL: https://github.com/apache/helix/pull/1594#discussion_r544629436



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java
##########
@@ -263,7 +262,7 @@ private Response batchGetStoppableInstances(String clusterId, JsonNode node, boo
         break;
       case instance_based:
       default:
-        throw new NotImplementedException("instance_based selection is not supported yet!");
+        throw new UnsupportedOperationException();

Review comment:
       My apologies.  That was a silly omission by me.  Thank you for catching it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org