[GitHub] [incubator-superset] JasonD28 opened a new pull request #10454: fix: Implement updates to SQL-based email alerts

[GitBox <gi...@apache.org>]

JasonD28 opened a new pull request #10454:
URL: https://github.com/apache/incubator-superset/pull/10454


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
    - Added unit testing for some functionality introduced through SQL-based email alerts
    - Removed unused fields from AlertModelView
    - Fix retention of past calls made to alert schedules
       - The celery alerting task is meant to be invoked every minute, however the previous implementation of `schedule_window()` ignored the timestamp of previous calls to alerting schedules, this resulted in alerts being sent out every time the task was invoked
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk merged pull request #10454: fix: Implement updates to SQL-based email alerts

[GitBox <gi...@apache.org>]

bkyryliuk merged pull request #10454:
URL: https://github.com/apache/incubator-superset/pull/10454


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10454: fix: Implement updates to SQL-based email alerts

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #10454:
URL: https://github.com/apache/incubator-superset/pull/10454#discussion_r461830409



##########
File path: tests/alerts_tests.py
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Unit tests for alerting in Superset"""
+import logging
+import unittest
+from unittest.mock import patch
+
+from superset import db
+from superset.models.alerts import Alert, AlertLog
+from superset.models.slice import Slice
+from superset.tasks.schedules import run_alert_query
+from superset.utils import core as utils
+from tests.base_tests import SupersetTestCase
+
+logging.basicConfig(level=logging.INFO)
+logger = logging.getLogger(__name__)
+
+
+class TestAlerts(SupersetTestCase):
+    def setUp(self):

Review comment:
       let's use pytest fixtures, superset uses pytest now




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org