You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/13 17:11:56 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request #3858: [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs
HappenLee opened a new pull request #3858:
URL: https://github.com/apache/incubator-doris/pull/3858
RT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3858: [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #3858:
URL: https://github.com/apache/incubator-doris/pull/3858#discussion_r441388234
##########
File path: docs/zh-CN/administrator-guide/running-profile.md
##########
@@ -92,18 +92,23 @@ BE端收集的统计信息较多，下面列出了各个参数的对应含义：
- AverageThreadTokens: 执行Fragment使用线程数目，不包含线程池的使用情况
- Buffer Pool PeakReservation: Buffer Pool使用的内存的峰值
- MemoryLimit: 查询时的内存限制
- - PeakMemoryUsage: 内存使用的峰值
+ - PeakMemoryUsage: 整个Fragment在查询时内存使用的峰值
Review comment:
Fragment -> 1个instance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3858: [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #3858:
URL: https://github.com/apache/incubator-doris/pull/3858#discussion_r441423822
##########
File path: docs/zh-CN/administrator-guide/running-profile.md
##########
@@ -92,18 +92,23 @@ BE端收集的统计信息较多，下面列出了各个参数的对应含义：
- AverageThreadTokens: 执行Fragment使用线程数目，不包含线程池的使用情况
- Buffer Pool PeakReservation: Buffer Pool使用的内存的峰值
- MemoryLimit: 查询时的内存限制
- - PeakMemoryUsage: 内存使用的峰值
+ - PeakMemoryUsage: 整个Fragment在查询时内存使用的峰值
- RowsProduced: 处理列的行数
- - BytesReceived: 通过网络接收的Bytes大小
- - DeserializeRowBatchTimer: 反序列化的耗时
#### `BlockMgr`
- - BlocksCreated: 落盘时创建的Blocks数目
+ - BlocksCreated: BlockMgr创建的Blocks数目
- BlocksRecycled: 重用的Blocks数目
- BytesWritten: 总的落盘写数据量
- MaxBlockSize: 单个Block的大小
- TotalReadBlockTime: 读Block的总耗时
+#### `DataStreamRecvr`
+ - BytesReceived: 通过网络接收的数据量大小
+ - DataArrivalWaitTime: 等待Sender发送数据的总时间
+ - FirstBatchArrivalWaitTime: 等待第一个batch从Sender获取的时间
+ - DeserializeRowBatchTimer: 反序列化网络数据的耗时
+ - SendersBlockedTotalTimer(*): DataStreamRecv的队列的内存被打满，Sender端等待的耗时
+
Review comment:
DataStreamRecv放在exchangeNode里面
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #3858: [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3858:
URL: https://github.com/apache/incubator-doris/pull/3858#discussion_r440120241
##########
File path: be/src/runtime/data_stream_recvr.h
##########
@@ -163,6 +163,7 @@ class DataStreamRecvr {
// receiver and placed in _sender_queue_pool.
std::vector<SenderQueue*> _sender_queues;
+ std::map<google::protobuf::Closure*, MonotonicStopWatch> _closere_clock_map;
Review comment:
```suggestion
std::map<google::protobuf::Closure*, MonotonicStopWatch> _closure_clock_map;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3858: [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs
Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #3858:
URL: https://github.com/apache/incubator-doris/pull/3858#discussion_r442601667
##########
File path: docs/zh-CN/administrator-guide/running-profile.md
##########
@@ -92,18 +92,23 @@ BE端收集的统计信息较多，下面列出了各个参数的对应含义：
- AverageThreadTokens: 执行Fragment使用线程数目，不包含线程池的使用情况
- Buffer Pool PeakReservation: Buffer Pool使用的内存的峰值
- MemoryLimit: 查询时的内存限制
- - PeakMemoryUsage: 内存使用的峰值
+ - PeakMemoryUsage: 整个Fragment在查询时内存使用的峰值
- RowsProduced: 处理列的行数
- - BytesReceived: 通过网络接收的Bytes大小
- - DeserializeRowBatchTimer: 反序列化的耗时
#### `BlockMgr`
- - BlocksCreated: 落盘时创建的Blocks数目
+ - BlocksCreated: BlockMgr创建的Blocks数目
- BlocksRecycled: 重用的Blocks数目
- BytesWritten: 总的落盘写数据量
- MaxBlockSize: 单个Block的大小
- TotalReadBlockTime: 读Block的总耗时
+#### `DataStreamRecvr`
+ - BytesReceived: 通过网络接收的数据量大小
+ - DataArrivalWaitTime: 等待Sender发送数据的总时间
+ - FirstBatchArrivalWaitTime: 等待第一个batch从Sender获取的时间
+ - DeserializeRowBatchTimer: 反序列化网络数据的耗时
+ - SendersBlockedTotalTimer(*): DataStreamRecv的队列的内存被打满，Sender端等待的耗时
+
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3858: [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3858:
URL: https://github.com/apache/incubator-doris/pull/3858
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3858: [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs
Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #3858:
URL: https://github.com/apache/incubator-doris/pull/3858#discussion_r442601729
##########
File path: docs/zh-CN/administrator-guide/running-profile.md
##########
@@ -92,18 +92,23 @@ BE端收集的统计信息较多，下面列出了各个参数的对应含义：
- AverageThreadTokens: 执行Fragment使用线程数目，不包含线程池的使用情况
- Buffer Pool PeakReservation: Buffer Pool使用的内存的峰值
- MemoryLimit: 查询时的内存限制
- - PeakMemoryUsage: 内存使用的峰值
+ - PeakMemoryUsage: 整个Fragment在查询时内存使用的峰值
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org