You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/11 23:22:00 UTC

[GitHub] [incubator-tvm] rkimball opened a new pull request #6460: Add a make style target for linux and hopefully macos

rkimball opened a new pull request #6460:
URL: https://github.com/apache/incubator-tvm/pull/6460


   Add a new target `make style` which applies clang-format to all *.cc and *.h file in the following directories. You will need to have clang-format-10 installed.
   The directory list processed is
   * src
   * include
   * golang
   * nnvm
   * tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] rkimball commented on pull request #6460: Add a make style target for linux and hopefully macos

Posted by GitBox <gi...@apache.org>.
rkimball commented on pull request #6460:
URL: https://github.com/apache/incubator-tvm/pull/6460#issuecomment-691351548


   @tqchen 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen closed pull request #6460: Add a make style target for linux and hopefully macos

Posted by GitBox <gi...@apache.org>.
tqchen closed pull request #6460:
URL: https://github.com/apache/incubator-tvm/pull/6460






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #6460: Add a make style target for linux and hopefully macos

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6460:
URL: https://github.com/apache/incubator-tvm/pull/6460#issuecomment-691527355


   close for now as per above comment


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #6460: Add a make style target for linux and hopefully macos

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6460:
URL: https://github.com/apache/incubator-tvm/pull/6460#issuecomment-691359121






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen closed pull request #6460: Add a make style target for linux and hopefully macos

Posted by GitBox <gi...@apache.org>.
tqchen closed pull request #6460:
URL: https://github.com/apache/incubator-tvm/pull/6460






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #6460: Add a make style target for linux and hopefully macos

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6460:
URL: https://github.com/apache/incubator-tvm/pull/6460#issuecomment-691359121






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #6460: Add a make style target for linux and hopefully macos

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6460:
URL: https://github.com/apache/incubator-tvm/pull/6460#issuecomment-691359245


   Please also see https://github.com/apache/incubator-tvm/blob/master/tests/lint/clang_format.sh


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] rkimball commented on pull request #6460: Add a make style target for linux and hopefully macos

Posted by GitBox <gi...@apache.org>.
rkimball commented on pull request #6460:
URL: https://github.com/apache/incubator-tvm/pull/6460#issuecomment-691351548






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen closed pull request #6460: Add a make style target for linux and hopefully macos

Posted by GitBox <gi...@apache.org>.
tqchen closed pull request #6460:
URL: https://github.com/apache/incubator-tvm/pull/6460


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #6460: Add a make style target for linux and hopefully macos

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6460:
URL: https://github.com/apache/incubator-tvm/pull/6460#issuecomment-691359121


   Thanks @rkimball We already have a script for applying clang-format. `./tests/lint/git-clang-format.sh upstream/master` usually resolves all the clang-format issues
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] rkimball commented on pull request #6460: Add a make style target for linux and hopefully macos

Posted by GitBox <gi...@apache.org>.
rkimball commented on pull request #6460:
URL: https://github.com/apache/incubator-tvm/pull/6460#issuecomment-691351548






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org