[jira] [Commented] (YARN-6245) Add FinalResource object to reduce overhead of Resource class instancing

["Karthik Kambatla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890378#comment-15890378 ] 

Karthik Kambatla commented on YARN-6245:
----------------------------------------

[~leftnoteasy] - I didn't understand you question about immutable_add. In FairScheduler, there is a lot of {{Resources.addTo}}. This can be performed on a {{Resource}} and the corresponding getter can return {{Resource.getObservableCopy}}.

YARN-3926 needs to be incorporated carefully. I haven't looked at the code there, but will we still be using Resource? If yes, we will have to implement all the methods in Resource. 

> Add FinalResource object to reduce overhead of Resource class instancing
> ------------------------------------------------------------------------
>
>                 Key: YARN-6245
>                 URL: https://issues.apache.org/jira/browse/YARN-6245
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>         Attachments: observable-resource.patch, YARN-6245.preliminary-staled.1.patch
>
>
> There're lots of Resource object creation in YARN Scheduler, since Resource object is backed by protobuf, creation of such objects is expensive and becomes bottleneck.
> To address the problem, we can introduce a FinalResource (Is it better to call it ImmutableResource?) object, which is not backed by PBImpl. We can use this object in frequent invoke paths in the scheduler.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org