You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Pengzna (via GitHub)" <gi...@apache.org> on 2024/11/18 02:30:25 UTC

[PR] [remove datanode] Procedure no longer acquires node lock [iotdb]

Pengzna opened a new pull request, #14115:
URL: https://github.com/apache/iotdb/pull/14115

   as title.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [remove datanode] Procedure no longer acquires node lock [iotdb]

Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum merged PR #14115:
URL: https://github.com/apache/iotdb/pull/14115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [remove datanode] Procedure no longer acquires node lock [iotdb]

Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on PR #14115:
URL: https://github.com/apache/iotdb/pull/14115#issuecomment-2490887422

   | hi , why do no need node lock? if have some addnodeprocedure perform now, our remove other node, whether is effect?
   
   Hi, chao, this is because we have do check before executing RemoveDataNode Procedure(you could see the code in https://github.com/apache/iotdb/blob/master/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java#L619-L725).
   
   Currently, only one removeDataNode task is allowed globally, so there is no need for additional concurrency control during procedure execution, otherwise it may cause some mutual blocking with pipe
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [remove datanode] Procedure no longer acquires node lock [iotdb]

Posted by "wangchao316 (via GitHub)" <gi...@apache.org>.
wangchao316 commented on PR #14115:
URL: https://github.com/apache/iotdb/pull/14115#issuecomment-2487859588

   hi , why do no need node lock?   if have some addnodeprocedure perform now, our remove other node,   whether is effect? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [remove datanode] Procedure no longer acquires node lock [iotdb]

Posted by "Pengzna (via GitHub)" <gi...@apache.org>.
Pengzna commented on PR #14115:
URL: https://github.com/apache/iotdb/pull/14115#issuecomment-2493457122

   > hi , why do no need node lock? if have some addnodeprocedure perform now, our remove other node, whether is effect?
   
   hi, sorry for replying late, I just saw this message. As @OneSizeFitsQuorum  said, the upper layer of the procedure has been guaranteed to be safe, so the lock here is unnecessary because it may block other procedures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org