[GitHub] [lucene-solr] dweiss commented on a change in pull request #2319: LUCENE-9743: Hunspell: ignore original tests which are out of scope

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #2319:
URL: https://github.com/apache/lucene-solr/pull/2319#discussion_r571918529



##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestHunspellRepositoryTestCases.java
##########
@@ -64,7 +74,12 @@ public TestHunspellRepositoryTestCases(String testName, Path pathPrefix) {
   }
 
   @Test
-  public void test() throws IOException, ParseException {
-    SpellCheckerTest.checkSpellCheckerExpectations(pathPrefix, false);
+  public void test() throws Throwable {
+    ThrowingRunnable test = () -> SpellCheckerTest.checkSpellCheckerExpectations(pathPrefix);
+    if (IGNORED.contains(testName)) {

Review comment:
       It should perhaps read FAILING instead of ignored if you're still running the test and testing the outcome? 

##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestHunspellRepositoryTestCases.java
##########
@@ -36,9 +37,18 @@
  */
 @RunWith(Parameterized.class)
 public class TestHunspellRepositoryTestCases {
+  private static final Set<String> IGNORED =
+      Set.of(
+          "hu", // Hungarian is hard: a lot of its rules are hardcoded in Hunspell code, not aff/dic

Review comment:
       Hungarian is hard, isn't it! :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org