You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2016/04/21 23:01:41 UTC
Review Request 46513: YARN ATS Should Advertise a Version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46513/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-16026
https://issues.apache.org/jira/browse/AMBARI-16026
Repository: ambari
Description
-------
In YARN's {{metainfo.xml}}, ATS does not have a {{versionAdvertised}} element. As a result, the absence of this element causes Ambari to think that YARN is not part of the {{hdp-select}} logic and we will never validate that it is reporting the correct version on startup.
However, YARN ATS does have a version and an entry in {{hdp-select}}:
```
if params.version and check_stack_feature(StackFeature.ROLLING_UPGRADE, params.version):
conf_select.select(params.stack_name, "hadoop", params.version)
stack_select.select("hadoop-yarn-timelineserver", params.version)
```
```
[root@c6401 ~]# cat /usr/bin/hdp-select | grep "timeline"
"hadoop-yarn-timelineserver": "hadoop-yarn",
"hadoop-yarn-timelineserver"],
```
This actually causes the ATS component to say it has a {{VERSION_MISMATCH}} since upgrading HDP changes it's version when we were not expecting it to:
```
YARN_CLIENT 2.4.2.0-39 COMPLETE UNKNOWN
APP_TIMELINE_SERVER 2.4.2.0-39 VERSION_MISMATCH UNSECURED
ZOOKEEPER_SERVER 2.4.2.0-39 COMPLETE UNSECURED
```
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/metainfo.xml 2ebc3d7
Diff: https://reviews.apache.org/r/46513/diff/
Testing
-------
Verified that ats existing in earlier version of HDP and successfully upgraded from that old version.
Thanks,
Jonathan Hurley
Re: Review Request 46513: YARN ATS Should Advertise a Version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46513/#review129956
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On April 21, 2016, 5:01 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46513/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 5:01 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-16026
> https://issues.apache.org/jira/browse/AMBARI-16026
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In YARN's {{metainfo.xml}}, ATS does not have a {{versionAdvertised}} element. As a result, the absence of this element causes Ambari to think that YARN is not part of the {{hdp-select}} logic and we will never validate that it is reporting the correct version on startup.
>
> However, YARN ATS does have a version and an entry in {{hdp-select}}:
> ```
> if params.version and check_stack_feature(StackFeature.ROLLING_UPGRADE, params.version):
> conf_select.select(params.stack_name, "hadoop", params.version)
> stack_select.select("hadoop-yarn-timelineserver", params.version)
> ```
>
> ```
> [root@c6401 ~]# cat /usr/bin/hdp-select | grep "timeline"
> "hadoop-yarn-timelineserver": "hadoop-yarn",
> "hadoop-yarn-timelineserver"],
> ```
>
> This actually causes the ATS component to say it has a {{VERSION_MISMATCH}} since upgrading HDP changes it's version when we were not expecting it to:
>
> ```
> YARN_CLIENT 2.4.2.0-39 COMPLETE UNKNOWN
> APP_TIMELINE_SERVER 2.4.2.0-39 VERSION_MISMATCH UNSECURED
> ZOOKEEPER_SERVER 2.4.2.0-39 COMPLETE UNSECURED
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/metainfo.xml 2ebc3d7
>
> Diff: https://reviews.apache.org/r/46513/diff/
>
>
> Testing
> -------
>
> Verified that ats existing in earlier version of HDP and successfully upgraded from that old version.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 46513: YARN ATS Should Advertise a Version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46513/#review129967
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 21, 2016, 9:01 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46513/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 9:01 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-16026
> https://issues.apache.org/jira/browse/AMBARI-16026
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In YARN's {{metainfo.xml}}, ATS does not have a {{versionAdvertised}} element. As a result, the absence of this element causes Ambari to think that YARN is not part of the {{hdp-select}} logic and we will never validate that it is reporting the correct version on startup.
>
> However, YARN ATS does have a version and an entry in {{hdp-select}}:
> ```
> if params.version and check_stack_feature(StackFeature.ROLLING_UPGRADE, params.version):
> conf_select.select(params.stack_name, "hadoop", params.version)
> stack_select.select("hadoop-yarn-timelineserver", params.version)
> ```
>
> ```
> [root@c6401 ~]# cat /usr/bin/hdp-select | grep "timeline"
> "hadoop-yarn-timelineserver": "hadoop-yarn",
> "hadoop-yarn-timelineserver"],
> ```
>
> This actually causes the ATS component to say it has a {{VERSION_MISMATCH}} since upgrading HDP changes it's version when we were not expecting it to:
>
> ```
> YARN_CLIENT 2.4.2.0-39 COMPLETE UNKNOWN
> APP_TIMELINE_SERVER 2.4.2.0-39 VERSION_MISMATCH UNSECURED
> ZOOKEEPER_SERVER 2.4.2.0-39 COMPLETE UNSECURED
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/metainfo.xml 2ebc3d7
>
> Diff: https://reviews.apache.org/r/46513/diff/
>
>
> Testing
> -------
>
> Verified that ats existing in earlier version of HDP and successfully upgraded from that old version.
>
>
> Thanks,
>
> Jonathan Hurley
>
>