You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/27 23:53:18 UTC
[GitHub] [hbase] bharathv opened a new pull request #1096: HBASE-23275:
Track active master's address in ActiveMasterManager (#812)
bharathv opened a new pull request #1096: HBASE-23275: Track active master's address in ActiveMasterManager (#812)
URL: https://github.com/apache/hbase/pull/1096
Currently we just track whether an active master exists.
It helps to also track the address of the active master in
all the masters to help serve the client RPC requests to
know which master is active.
Signed-off-by: Nick Dimiduk <nd...@apache.org>
Signed-off-by: Andrew Purtell <ap...@apache.org>
(cherry picked from commit efebb84)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] apurtell commented on a change in pull request #1096:
HBASE-23275: Track active master's address in ActiveMasterManager (#812)
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #1096: HBASE-23275: Track active master's address in ActiveMasterManager (#812)
URL: https://github.com/apache/hbase/pull/1096#discussion_r372135345
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/CachedClusterId.java
##########
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.master;
+
+import java.io.IOException;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.ClusterId;
+import org.apache.hadoop.hbase.util.FSUtils;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
+import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+
+/**
+ * Caches the cluster ID of the cluster. For standby masters, this is used to serve the client
+ * RPCs that fetch the cluster ID. ClusterID is only created by an active master if one does not
+ * already exist. Standby masters just read the information from the file system. This class is
+ * thread-safe.
+ *
+ * TODO: Make it a singleton without affecting concurrent junit tests.
+ */
+@InterfaceAudience.Private
+public class CachedClusterId {
+
+ public static final Logger LOG = LoggerFactory.getLogger(CachedClusterId.class);
+ private static final int MAX_FETCH_TIMEOUT_MS = 10000;
+
+ private Path rootDir;
+ private FileSystem fs;
+
+ // When true, indicates that a FileSystem fetch of ClusterID is in progress. This is used to
+ // avoid multiple fetches from FS and let only one thread fetch the information.
+ AtomicBoolean fetchInProgress = new AtomicBoolean(false);
+
+ // When true, it means that the cluster ID has been fetched successfully from fs.
+ private AtomicBoolean isClusterIdSet = new AtomicBoolean(false);
+ // Immutable once set and read multiple times.
+ private ClusterId clusterId;
+
+ // cache stats for testing.
+ private AtomicInteger cacheMisses = new AtomicInteger(0);
+
+ public CachedClusterId(Configuration conf) throws IOException {
+ rootDir = FSUtils.getRootDir(conf);
+ fs = rootDir.getFileSystem(conf);
+ }
+
+ /**
+ * Succeeds only once, when setting to a non-null value. Overwrites are not allowed.
+ */
+ private void setClusterId(ClusterId id) {
+ if (id == null || isClusterIdSet.get()) {
+ return;
+ }
+ clusterId = id;
+ isClusterIdSet.set(true);
+ }
+
+ /**
+ * Returns a cached copy of the cluster ID. null if the cache is not populated.
+ */
+ private String getClusterId() {
+ if (!isClusterIdSet.get()) {
+ return null;
+ }
+ // It is ok to read without a lock since clusterId is immutable once set.
+ return clusterId.toString();
+ }
+
+ /**
+ * Attempts to fetch the cluster ID from the file system. If no attempt is already in progress,
+ * synchronously fetches the cluster ID and sets it. If an attempt is already in progress,
+ * returns right away and the caller is expected to wait for the fetch to finish.
+ * @return true if the attempt is done, false if another thread is already fetching it.
+ */
+ private boolean attemptFetch() {
+ if (fetchInProgress.compareAndSet(false, true)) {
+ // A fetch is not in progress, so try fetching the cluster ID synchronously and then notify
+ // the waiting threads.
+ try {
+ cacheMisses.incrementAndGet();
+ setClusterId(FSUtils.getClusterId(fs, rootDir));
+ } catch (IOException e) {
+ LOG.warn("Error fetching cluster ID", e);
+ } finally {
+ Preconditions.checkState(fetchInProgress.compareAndSet(true, false));
+ synchronized (fetchInProgress) {
+ fetchInProgress.notifyAll();
+ }
+ }
+ return true;
+ }
+ return false;
+ }
+
+ private void waitForFetchToFinish() throws InterruptedException {
+ synchronized (fetchInProgress) {
+ while (fetchInProgress.get()) {
+ // We don't want the fetches to block forever, for example if there are bugs
+ // of missing notifications.
+ fetchInProgress.wait(MAX_FETCH_TIMEOUT_MS);
Review comment:
Oh forgot to mention this while looking at the master patch. You will miss the notification for sure if the Preconditions check above throws an exception. Doesn't seem wrong, just thought I'd mention it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] apurtell commented on a change in pull request #1096:
HBASE-23275: Track active master's address in ActiveMasterManager (#812)
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #1096: HBASE-23275: Track active master's address in ActiveMasterManager (#812)
URL: https://github.com/apache/hbase/pull/1096#discussion_r372135013
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/CachedClusterId.java
##########
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.master;
+
+import java.io.IOException;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.ClusterId;
+import org.apache.hadoop.hbase.util.FSUtils;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
+import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+
+/**
+ * Caches the cluster ID of the cluster. For standby masters, this is used to serve the client
+ * RPCs that fetch the cluster ID. ClusterID is only created by an active master if one does not
+ * already exist. Standby masters just read the information from the file system. This class is
+ * thread-safe.
+ *
+ * TODO: Make it a singleton without affecting concurrent junit tests.
+ */
+@InterfaceAudience.Private
+public class CachedClusterId {
+
+ public static final Logger LOG = LoggerFactory.getLogger(CachedClusterId.class);
+ private static final int MAX_FETCH_TIMEOUT_MS = 10000;
+
+ private Path rootDir;
+ private FileSystem fs;
+
+ // When true, indicates that a FileSystem fetch of ClusterID is in progress. This is used to
+ // avoid multiple fetches from FS and let only one thread fetch the information.
+ AtomicBoolean fetchInProgress = new AtomicBoolean(false);
+
+ // When true, it means that the cluster ID has been fetched successfully from fs.
+ private AtomicBoolean isClusterIdSet = new AtomicBoolean(false);
+ // Immutable once set and read multiple times.
+ private ClusterId clusterId;
+
+ // cache stats for testing.
+ private AtomicInteger cacheMisses = new AtomicInteger(0);
Review comment:
Same comment as per the master version of this change: A bit wasteful just for a unit test? Nit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1096: HBASE-23275: Track
active master's address in ActiveMasterManager (#812)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1096: HBASE-23275: Track active master's address in ActiveMasterManager (#812)
URL: https://github.com/apache/hbase/pull/1096#issuecomment-579065532
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 56s | branch-2 passed |
| +1 :green_heart: | compile | 0m 57s | branch-2 passed |
| +1 :green_heart: | checkstyle | 1m 17s | branch-2 passed |
| +1 :green_heart: | shadedjars | 4m 38s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 41s | branch-2 passed |
| +0 :ok: | spotbugs | 3m 30s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 28s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 26s | the patch passed |
| +1 :green_heart: | compile | 0m 59s | the patch passed |
| +1 :green_heart: | javac | 0m 59s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 14s | hbase-server: The patch generated 0 new + 106 unchanged - 6 fixed = 106 total (was 112) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 41s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 4s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
| +1 :green_heart: | findbugs | 3m 40s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 165m 0s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. |
| | | 224m 8s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.client.TestAsyncTableGetMultiThreaded |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1096/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1096 |
| JIRA Issue | HBASE-23275 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 3474081bae23 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1096/out/precommit/personality/provided.sh |
| git revision | branch-2 / e0f913323e |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1096/1/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1096/1/testReport/ |
| Max. process+thread count | 4823 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1096/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] apurtell commented on a change in pull request #1096:
HBASE-23275: Track active master's address in ActiveMasterManager (#812)
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #1096: HBASE-23275: Track active master's address in ActiveMasterManager (#812)
URL: https://github.com/apache/hbase/pull/1096#discussion_r372134729
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
##########
@@ -17,25 +17,24 @@
* limitations under the License.
*/
package org.apache.hadoop.hbase.master;
-
import java.io.IOException;
+import java.util.Optional;
import java.util.concurrent.atomic.AtomicBoolean;
-
-import org.apache.hadoop.hbase.zookeeper.MasterAddressTracker;
-import org.apache.hadoop.hbase.zookeeper.ZKUtil;
-import org.apache.hadoop.hbase.zookeeper.ZKWatcher;
-import org.apache.hadoop.hbase.zookeeper.ZNodePaths;
-import org.apache.yetus.audience.InterfaceAudience;
import org.apache.hadoop.hbase.Server;
import org.apache.hadoop.hbase.ServerName;
import org.apache.hadoop.hbase.ZNodeClearer;
import org.apache.hadoop.hbase.exceptions.DeserializationException;
import org.apache.hadoop.hbase.monitoring.MonitoredTask;
-import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.zookeeper.MasterAddressTracker;
import org.apache.hadoop.hbase.zookeeper.ZKListener;
+import org.apache.hadoop.hbase.zookeeper.ZKUtil;
+import org.apache.hadoop.hbase.zookeeper.ZKWatcher;
+import org.apache.hadoop.hbase.zookeeper.ZNodePaths;
+import org.apache.yetus.audience.InterfaceAudience;
import org.apache.zookeeper.KeeperException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
Review comment:
Does this show up as a checkstyle nit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv closed pull request #1096: HBASE-23275: Track
active master's address in ActiveMasterManager (#812)
Posted by GitBox <gi...@apache.org>.
bharathv closed pull request #1096: HBASE-23275: Track active master's address in ActiveMasterManager (#812)
URL: https://github.com/apache/hbase/pull/1096
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on issue #1096: HBASE-23275: Track
active master's address in ActiveMasterManager (#812)
Posted by GitBox <gi...@apache.org>.
bharathv commented on issue #1096: HBASE-23275: Track active master's address in ActiveMasterManager (#812)
URL: https://github.com/apache/hbase/pull/1096#issuecomment-579542165
Will be merged as a part of #1098
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] apurtell commented on a change in pull request #1096:
HBASE-23275: Track active master's address in ActiveMasterManager (#812)
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #1096: HBASE-23275: Track active master's address in ActiveMasterManager (#812)
URL: https://github.com/apache/hbase/pull/1096#discussion_r372135673
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
##########
@@ -17,25 +17,24 @@
* limitations under the License.
*/
package org.apache.hadoop.hbase.master;
-
import java.io.IOException;
+import java.util.Optional;
import java.util.concurrent.atomic.AtomicBoolean;
-
-import org.apache.hadoop.hbase.zookeeper.MasterAddressTracker;
-import org.apache.hadoop.hbase.zookeeper.ZKUtil;
-import org.apache.hadoop.hbase.zookeeper.ZKWatcher;
-import org.apache.hadoop.hbase.zookeeper.ZNodePaths;
-import org.apache.yetus.audience.InterfaceAudience;
import org.apache.hadoop.hbase.Server;
import org.apache.hadoop.hbase.ServerName;
import org.apache.hadoop.hbase.ZNodeClearer;
import org.apache.hadoop.hbase.exceptions.DeserializationException;
import org.apache.hadoop.hbase.monitoring.MonitoredTask;
-import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.zookeeper.MasterAddressTracker;
import org.apache.hadoop.hbase.zookeeper.ZKListener;
+import org.apache.hadoop.hbase.zookeeper.ZKUtil;
+import org.apache.hadoop.hbase.zookeeper.ZKWatcher;
+import org.apache.hadoop.hbase.zookeeper.ZNodePaths;
+import org.apache.yetus.audience.InterfaceAudience;
import org.apache.zookeeper.KeeperException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
Review comment:
I guess it doesn't, never mind...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services