[GitHub] [accumulo] ctubbsii commented on a change in pull request #1068: Revert commons config to 1.6

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1068: Revert commons config to 1.6
URL: https://github.com/apache/accumulo/pull/1068#discussion_r271331466
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java
 ##########
 @@ -656,16 +656,6 @@ public void addConfiguration(Configuration config) {
     super.addConfiguration(config);
   }
 
-  /**
-   * @deprecated since 1.9.2; will be removed in 2.0.0 to eliminate commons config leakage into
-   *             Accumulo API
-   */
-  @Deprecated
-  @Override
-  public void addConfiguration(Configuration config, boolean asInMemory) {
 
 Review comment:
   No. This was specifically added in your previous PR for 1.9.3 https://github.com/apache/accumulo/pull/659/files
   
   Recall that we deprecated the superclass of ClientConfiguration, and added in all the methods inherited from the superclass, to mark them with the Deprecated annotation. This was a new method between 1.6 and 1.10, that was included here merely to declare it as Deprecated (since once cannot annotate the superclass directly, only its inherited methods).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services