You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/08/28 13:46:16 UTC
Review Request 71389: Added CHANGELOG entry for agent draining.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71389/
-----------------------------------------------------------
Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
Repository: mesos
Description
-------
Added CHANGELOG entry for agent draining.
Diffs
-----
CHANGELOG 935463849cc937e82d01254624ca10a11b9ad5ee
docs/upgrades.md 63eb1bbe401d4fb36e11e595a6b1954793265b33
Diff: https://reviews.apache.org/r/71389/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71389: Added CHANGELOG entry for agent draining.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71389/#review217480
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 28, 2019, 2:24 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71389/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2019, 2:24 p.m.)
>
>
> Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added CHANGELOG entry for agent draining.
>
>
> Diffs
> -----
>
> CHANGELOG 935463849cc937e82d01254624ca10a11b9ad5ee
> docs/upgrades.md 63eb1bbe401d4fb36e11e595a6b1954793265b33
>
>
> Diff: https://reviews.apache.org/r/71389/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71389: Added CHANGELOG entry for agent draining.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71389/
-----------------------------------------------------------
(Updated Aug. 28, 2019, 2:24 p.m.)
Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
Repository: mesos
Description
-------
Added CHANGELOG entry for agent draining.
Diffs (updated)
-----
CHANGELOG 935463849cc937e82d01254624ca10a11b9ad5ee
docs/upgrades.md 63eb1bbe401d4fb36e11e595a6b1954793265b33
Diff: https://reviews.apache.org/r/71389/diff/2/
Changes: https://reviews.apache.org/r/71389/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71389: Added CHANGELOG entry for agent draining.
Posted by Benno Evers <be...@mesosphere.com>.
> On Aug. 28, 2019, 2:02 p.m., Greg Mann wrote:
> > CHANGELOG
> > Lines 5-11 (patched)
> > <https://reviews.apache.org/r/71389/diff/1/?file=2163055#file2163055line5>
> >
> > Let's remove this since https://reviews.apache.org/r/71378/ added a changelog entry.
In addition, I moved the entry from r/71378 under the `Maintenance` subheading.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71389/#review217478
-----------------------------------------------------------
On Aug. 28, 2019, 2:24 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71389/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2019, 2:24 p.m.)
>
>
> Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added CHANGELOG entry for agent draining.
>
>
> Diffs
> -----
>
> CHANGELOG 935463849cc937e82d01254624ca10a11b9ad5ee
> docs/upgrades.md 63eb1bbe401d4fb36e11e595a6b1954793265b33
>
>
> Diff: https://reviews.apache.org/r/71389/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71389: Added CHANGELOG entry for agent draining.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71389/#review217478
-----------------------------------------------------------
CHANGELOG
Lines 5-11 (patched)
<https://reviews.apache.org/r/71389/#comment304736>
Let's remove this since https://reviews.apache.org/r/71378/ added a changelog entry.
docs/upgrades.md
Lines 518-519 (patched)
<https://reviews.apache.org/r/71389/#comment304737>
Instead of "For agents....", let's say
"Once an agent is draining, all tasks running on that agent are gracefully killed and no offers for that agent are sent to schedulers, preventing the launching of new tasks."
- Greg Mann
On Aug. 28, 2019, 1:46 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71389/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2019, 1:46 p.m.)
>
>
> Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added CHANGELOG entry for agent draining.
>
>
> Diffs
> -----
>
> CHANGELOG 935463849cc937e82d01254624ca10a11b9ad5ee
> docs/upgrades.md 63eb1bbe401d4fb36e11e595a6b1954793265b33
>
>
> Diff: https://reviews.apache.org/r/71389/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>