You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2008/10/03 20:18:14 UTC

Re: svn commit: r33420 - trunk/subversion/mod_dav_svn

On Fri, Oct 3, 2008 at 12:23 PM,  <ar...@tigris.org> wrote:
>...
> +++ trunk/subversion/mod_dav_svn/activity.c     Fri Oct  3 12:23:56 2008        (r33420)
>...
> +  svn_checksum_t *checksum = svn_checksum_create(svn_checksum_md5, pool);
> +  svn_error_clear(svn_checksum(&checksum, svn_checksum_md5, activity_id,
> +                               strlen(activity_id), pool));

No need for the svn_checksum_create() call. The svn_checksum()
function allocates a checksum structure.

Cheers,
-g

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r33420 - trunk/subversion/mod_dav_svn

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-10-03 22:18:14 Greg Stein napisaƂ(a):
> On Fri, Oct 3, 2008 at 12:23 PM,  <ar...@tigris.org> wrote:
> >...
> > +++ trunk/subversion/mod_dav_svn/activity.c     Fri Oct  3 12:23:56 2008        (r33420)
> >...
> > +  svn_checksum_t *checksum = svn_checksum_create(svn_checksum_md5, pool);
> > +  svn_error_clear(svn_checksum(&checksum, svn_checksum_md5, activity_id,
> > +                               strlen(activity_id), pool));
> 
> No need for the svn_checksum_create() call. The svn_checksum()
> function allocates a checksum structure.

Fixed in r33426.

-- 
Arfrever Frehtes Taifersar Arahesis