You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/04/27 22:49:33 UTC
[GitHub] [incubator-pinot] codecov-io commented on pull request #5309: Decouple Schema from RecordReader and StreamMessageDecoder
codecov-io commented on pull request #5309:
URL: https://github.com/apache/incubator-pinot/pull/5309#issuecomment-620275758
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5309?src=pr&el=h1) Report
> Merging [#5309](https://codecov.io/gh/apache/incubator-pinot/pull/5309?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/bfddb7a34dc60c80c059facaf0df3f7247fe81f9&el=desc) will **decrease** coverage by `9.28%`.
> The diff coverage is `69.15%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5309?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5309 +/- ##
==========================================
- Coverage 66.10% 56.82% -9.29%
==========================================
Files 1070 1070
Lines 54562 54493 -69
Branches 8136 8130 -6
==========================================
- Hits 36069 30964 -5105
- Misses 15855 21109 +5254
+ Partials 2638 2420 -218
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5309?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...manager/realtime/HLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5309/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvSExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `0.00% <0.00%> (-80.94%)` | :arrow_down: |
| [...e/realtime/converter/RealtimeSegmentConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5309/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvUmVhbHRpbWVTZWdtZW50Q29udmVydGVyLmphdmE=) | `39.13% <0.00%> (-39.75%)` | :arrow_down: |
| [...ealtime/converter/RealtimeSegmentRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5309/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvUmVhbHRpbWVTZWdtZW50UmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (-58.34%)` | :arrow_down: |
| [...pache/pinot/plugin/inputformat/avro/AvroUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5309/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtYXZyby1iYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wbHVnaW4vaW5wdXRmb3JtYXQvYXZyby9BdnJvVXRpbHMuamF2YQ==) | `66.94% <ø> (-3.35%)` | :arrow_down: |
| [...ugin/inputformat/avro/KafkaAvroMessageDecoder.java](https://codecov.io/gh/apache/incubator-pinot/pull/5309/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtYXZyby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL2lucHV0Zm9ybWF0L2F2cm8vS2Fma2FBdnJvTWVzc2FnZURlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...gin/inputformat/avro/SimpleAvroMessageDecoder.java](https://codecov.io/gh/apache/incubator-pinot/pull/5309/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtYXZyby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL2lucHV0Zm9ybWF0L2F2cm8vU2ltcGxlQXZyb01lc3NhZ2VEZWNvZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../pinot/plugin/inputformat/orc/ORCRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5309/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3Qtb3JjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wbHVnaW4vaW5wdXRmb3JtYXQvb3JjL09SQ1JlY29yZFJlYWRlci5qYXZh) | `51.70% <0.00%> (-0.65%)` | :arrow_down: |
| [...pinot/plugin/inputformat/parquet/ParquetUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5309/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL2lucHV0Zm9ybWF0L3BhcnF1ZXQvUGFycXVldFV0aWxzLmphdmE=) | `38.63% <ø> (-29.94%)` | :arrow_down: |
| [...apache/pinot/spi/stream/StreamConsumerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5309/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvc3RyZWFtL1N0cmVhbUNvbnN1bWVyRmFjdG9yeS5qYXZh) | `100.00% <ø> (ø)` | |
| [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5309/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `48.09% <33.33%> (-21.11%)` | :arrow_down: |
| ... and [346 more](https://codecov.io/gh/apache/incubator-pinot/pull/5309/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5309?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5309?src=pr&el=footer). Last update [bfddb7a...14ffea1](https://codecov.io/gh/apache/incubator-pinot/pull/5309?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org