You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2013/01/18 22:31:55 UTC

Review Request: [OOZIE-1181] Dependency cache with configurations for eviction, ttl and max elements in memory

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9026/
-----------------------------------------------------------

Review request for oozie.


Description
-------

Cache based on ehcache which has eviction, ttl, max elements in memory and overflow to disk configurable


Diffs
-----

  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml 1435002 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/cache/EhcacheHCatDependencyCache.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/cache/WaitingActions.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/resources/ehcache-default.xml PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1435002 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/resources/ehcache.xml PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1435002 

Diff: https://reviews.apache.org/r/9026/diff/


Testing
-------


Thanks,

Rohini Palaniswamy


Re: Review Request: [OOZIE-1181] Dependency cache with configurations for eviction, ttl and max elements in memory

Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9026/#review15709
-----------------------------------------------------------


Since JMS connection close utilizing patterncount is TODO, can we abstract code that is common between ehCache impl and simpleCache impl to the parent class, to avoid duplication?

- Mona Chitnis


On Jan. 24, 2013, 9:51 p.m., Rohini Palaniswamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9026/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 9:51 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> Cache based on ehcache which has eviction, ttl, max elements in memory and overflow to disk configurable
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml 1437215 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/cache/EhcacheHCatDependencyCache.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/cache/WaitingActions.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/resources/ehcache-default.xml PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1437215 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/resources/ehcache.xml PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1437215 
> 
> Diff: https://reviews.apache.org/r/9026/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rohini Palaniswamy
> 
>


Re: Review Request: [OOZIE-1181] Dependency cache with configurations for eviction, ttl and max elements in memory

Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9026/#review16676
-----------------------------------------------------------

Ship it!


Ship It!

- Virag Kothari


On Feb. 16, 2013, 1:17 a.m., Rohini Palaniswamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9026/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2013, 1:17 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> Cache based on ehcache which has eviction, ttl, max elements in memory and overflow to disk configurable
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml 1446829 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java 1446829 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/hcat/WaitingAction.java 1446829 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/hcat/WaitingActions.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/resources/ehcache-default.xml PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1446829 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/resources/ehcache.xml PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1446829 
> 
> Diff: https://reviews.apache.org/r/9026/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rohini Palaniswamy
> 
>


Re: Review Request: [OOZIE-1181] Dependency cache with configurations for eviction, ttl and max elements in memory

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9026/
-----------------------------------------------------------

(Updated Feb. 16, 2013, 1:17 a.m.)


Review request for oozie.


Changes
-------

Rebased patch


Description
-------

Cache based on ehcache which has eviction, ttl, max elements in memory and overflow to disk configurable


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml 1446829 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java 1446829 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/hcat/WaitingAction.java 1446829 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/hcat/WaitingActions.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/resources/ehcache-default.xml PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1446829 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/resources/ehcache.xml PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1446829 

Diff: https://reviews.apache.org/r/9026/diff/


Testing
-------


Thanks,

Rohini Palaniswamy


Re: Review Request: [OOZIE-1181] Dependency cache with configurations for eviction, ttl and max elements in memory

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9026/
-----------------------------------------------------------

(Updated Jan. 24, 2013, 9:51 p.m.)


Review request for oozie.


Changes
-------

Fixed/removed tests that had transient failures.


Description
-------

Cache based on ehcache which has eviction, ttl, max elements in memory and overflow to disk configurable


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml 1437215 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/cache/EhcacheHCatDependencyCache.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/cache/WaitingActions.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/resources/ehcache-default.xml PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1437215 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/resources/ehcache.xml PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1437215 

Diff: https://reviews.apache.org/r/9026/diff/


Testing
-------


Thanks,

Rohini Palaniswamy