You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "František Dvořák (JIRA)" <ji...@apache.org> on 2012/08/07 14:39:08 UTC

[jira] [Created] (AMQCPP-419) Missing dependency on apr/apr-util in pkg-config and config files

František Dvořák created AMQCPP-419:
---------------------------------------

             Summary: Missing dependency on apr/apr-util in pkg-config and config files
                 Key: AMQCPP-419
                 URL: https://issues.apache.org/jira/browse/AMQCPP-419
             Project: ActiveMQ C++ Client
          Issue Type: Bug
          Components: CMS Impl, Decaf
    Affects Versions: 3.5.0
            Reporter: František Dvořák
            Assignee: Timothy Bish
            Priority: Minor
             Fix For: 3.5.0


Decaf header files depends on headers in apr and apr-util packages, which is not covered by activemq-cpp.pc and activemq-config files.

I'm sending a patch which adds a necessary flags and includes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (AMQCPP-419) Missing dependency on apr/apr-util in pkg-config and config files

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQCPP-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430542#comment-13430542 ] 

Timothy Bish commented on AMQCPP-419:
-------------------------------------

applied the fix for the activemq-config file.  It doesn't look like the apr / apu patch would play nice with the --with-apr and --with-apr-util way of using nonstandard APR installations.
                
> Missing dependency on apr/apr-util in pkg-config and config files
> -----------------------------------------------------------------
>
>                 Key: AMQCPP-419
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-419
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: CMS Impl, Decaf
>    Affects Versions: 3.5.0
>            Reporter: František Dvořák
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: build, patch
>             Fix For: 3.5.0
>
>         Attachments: apr-devel.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Decaf header files depends on headers in apr and apr-util packages, which is not covered by activemq-cpp.pc and activemq-config files.
> I'm sending a patch which adds a necessary flags and includes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (AMQCPP-419) Missing dependency on apr/apr-util in pkg-config and config files

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQCPP-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431100#comment-13431100 ] 

Timothy Bish commented on AMQCPP-419:
-------------------------------------

User should not need to set env vars to make the configure work, and if they did you need to include significant documentation which this patch doesn't do.  
                
> Missing dependency on apr/apr-util in pkg-config and config files
> -----------------------------------------------------------------
>
>                 Key: AMQCPP-419
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-419
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: CMS Impl, Decaf
>    Affects Versions: 3.5.0
>            Reporter: František Dvořák
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: build, patch
>             Fix For: 3.5.0
>
>         Attachments: apr-devel.diff, pkg-config-apr.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Decaf header files depends on headers in apr and apr-util packages, which is not covered by activemq-cpp.pc and activemq-config files.
> I'm sending a patch which adds a necessary flags and includes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Closed] (AMQCPP-419) Missing dependency on apr/apr-util in pkg-config and config files

Posted by "František Dvořák (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQCPP-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

František Dvořák closed AMQCPP-419.
-----------------------------------

    
> Missing dependency on apr/apr-util in pkg-config and config files
> -----------------------------------------------------------------
>
>                 Key: AMQCPP-419
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-419
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: CMS Impl, Decaf
>    Affects Versions: 3.5.0
>            Reporter: František Dvořák
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: build, patch
>             Fix For: 3.5.0
>
>         Attachments: apr-devel.diff, pkg-config-apr.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Decaf header files depends on headers in apr and apr-util packages, which is not covered by activemq-cpp.pc and activemq-config files.
> I'm sending a patch which adds a necessary flags and includes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Resolved] (AMQCPP-419) Missing dependency on apr/apr-util in pkg-config and config files

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQCPP-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQCPP-419.
---------------------------------

    Resolution: Fixed

Applied corrected part of the patch, looks good. 
                
> Missing dependency on apr/apr-util in pkg-config and config files
> -----------------------------------------------------------------
>
>                 Key: AMQCPP-419
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-419
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: CMS Impl, Decaf
>    Affects Versions: 3.5.0
>            Reporter: František Dvořák
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: build, patch
>             Fix For: 3.5.0
>
>         Attachments: apr-devel.diff, pkg-config-apr.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Decaf header files depends on headers in apr and apr-util packages, which is not covered by activemq-cpp.pc and activemq-config files.
> I'm sending a patch which adds a necessary flags and includes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (AMQCPP-419) Missing dependency on apr/apr-util in pkg-config and config files

Posted by "František Dvořák (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQCPP-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

František Dvořák updated AMQCPP-419:
------------------------------------

    Attachment: pkg-config-apr.diff

Right, there were a problem in regular expression when apr/apr-util were installed in non-standard prefix.

Attaching fixed patch (tested with --with-apr and --with-apr-util options, and with apr/apr-util in standard paths).

I think we can let only the pkg-config dependency on apr-1 and apr-util-1 instead of copying the flags. With apr/apr-util in non-standard path, user must set environment variable PKG_CONFIG_PATH (pkg-config will properly complain, if there will be something wrong).
                
> Missing dependency on apr/apr-util in pkg-config and config files
> -----------------------------------------------------------------
>
>                 Key: AMQCPP-419
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-419
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: CMS Impl, Decaf
>    Affects Versions: 3.5.0
>            Reporter: František Dvořák
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: build, patch
>             Fix For: 3.5.0
>
>         Attachments: apr-devel.diff, pkg-config-apr.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Decaf header files depends on headers in apr and apr-util packages, which is not covered by activemq-cpp.pc and activemq-config files.
> I'm sending a patch which adds a necessary flags and includes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (AMQCPP-419) Missing dependency on apr/apr-util in pkg-config and config files

Posted by "František Dvořák (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQCPP-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431104#comment-13431104 ] 

František Dvořák commented on AMQCPP-419:
-----------------------------------------

I'm sorry, bad wording. :-) Only projects using activemq-cpp, pkg-config, and with apr/apr-util in non-standard prefix would need set the PKG_CONFIG_PATH variable (which I think is common thing, when using pkg-config to search libraries).

But copying the CFLAGS directly into activemq-cpp.pc file will work too (although it's probably not so clean), and it's one-line change.
                
> Missing dependency on apr/apr-util in pkg-config and config files
> -----------------------------------------------------------------
>
>                 Key: AMQCPP-419
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-419
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: CMS Impl, Decaf
>    Affects Versions: 3.5.0
>            Reporter: František Dvořák
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: build, patch
>             Fix For: 3.5.0
>
>         Attachments: apr-devel.diff, pkg-config-apr.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Decaf header files depends on headers in apr and apr-util packages, which is not covered by activemq-cpp.pc and activemq-config files.
> I'm sending a patch which adds a necessary flags and includes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (AMQCPP-419) Missing dependency on apr/apr-util in pkg-config and config files

Posted by "František Dvořák (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQCPP-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

František Dvořák updated AMQCPP-419:
------------------------------------

    Attachment: apr-devel.diff

Add flags and includes to activemq-cpp.pc and activemq-config files.
                
> Missing dependency on apr/apr-util in pkg-config and config files
> -----------------------------------------------------------------
>
>                 Key: AMQCPP-419
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-419
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: CMS Impl, Decaf
>    Affects Versions: 3.5.0
>            Reporter: František Dvořák
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: build, patch
>             Fix For: 3.5.0
>
>         Attachments: apr-devel.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Decaf header files depends on headers in apr and apr-util packages, which is not covered by activemq-cpp.pc and activemq-config files.
> I'm sending a patch which adds a necessary flags and includes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira