[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #42: [FLINK-26308][FLINK-26471] Separate Flink job role from operator role

[GitBox <gi...@apache.org>]

gyfora commented on a change in pull request #42:
URL: https://github.com/apache/flink-kubernetes-operator/pull/42#discussion_r820266305



##########
File path: helm/flink-operator/values.yaml
##########
@@ -36,11 +36,16 @@ rbac:
 ingress:
   create: false
 
-serviceAccount:
+operatorServiceAccount:
   create: true
   annotations: {}
   name: "flink-operator"
 
+jobServiceAccount:
+  create: true
+  annotations: {"helm.sh/resource-policy": keep}

Review comment:
       could this simply be?
   ```
   annotations: 
       "helm.sh/resource-policy" : keep
   ```

##########
File path: examples/basic.yaml
##########
@@ -19,14 +19,14 @@
 apiVersion: flink.apache.org/v1alpha1
 kind: FlinkDeployment
 metadata:
-  namespace: default
+  namespace: flink-user

Review comment:
       I think we should not change this in the example




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org