You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2022/08/29 08:47:59 UTC
[kudu-CR] [bootstrap] Reduce the memory size consumed when bootstrap
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18924
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap
......................................................................
[bootstrap] Reduce the memory size consumed when bootstrap
When a tserver bootstrap, it will load all tablets metadata,
and will find out the maximum fs block id it seen to notify
the block manager to avoid generating duplicate ids.
However, a tablet may contains a large number of blocks,
that means it will consume a large amount of memory when
tablets parellel loaded when tserver bootstrap.
This patch optimize it to only find the maximum block id
of a tablet, instead of temporary store all block ids in
memory.
Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
---
M src/kudu/tablet/rowset_metadata.cc
M src/kudu/tablet/rowset_metadata.h
M src/kudu/tablet/tablet_metadata-test.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
5 files changed, 64 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/18924/1
--
To view, visit http://gerrit.cloudera.org:8080/18924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Gerrit-Change-Number: 18924
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [bootstrap] Reduce the memory size consumed when bootstrap
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18924 )
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap
......................................................................
Patch Set 4: Verified+1
The failed test is not related.
--
To view, visit http://gerrit.cloudera.org:8080/18924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Gerrit-Change-Number: 18924
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 08:35:05 +0000
Gerrit-HasComments: No
[kudu-CR] [bootstrap] Reduce the memory size consumed when bootstrap
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18924 )
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/rowset_metadata.cc
File src/kudu/tablet/rowset_metadata.cc:
http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/rowset_metadata.cc@302
PS3, Line 302: BlockIdContainer blocks;
> Done
Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/18924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Gerrit-Change-Number: 18924
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 16:56:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] [bootstrap] Reduce the memory size consumed when bootstrap
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18924
to look at the new patch set (#3).
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap
......................................................................
[bootstrap] Reduce the memory size consumed when bootstrap
When a tserver bootstrap, it will load all tablets metadata,
and will find out the maximum fs block id it seen to notify
the block manager to avoid generating duplicate ids.
However, a tablet may contains a large number of blocks,
that means it will consume a large amount of memory when
tablets parellel loaded when tserver bootstrap.
This patch optimize it to only find the maximum block id
of a tablet, instead of temporary store all block ids in
memory.
Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
---
M src/kudu/tablet/rowset_metadata.cc
M src/kudu/tablet/rowset_metadata.h
M src/kudu/tablet/tablet_metadata-test.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
5 files changed, 69 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/18924/3
--
To view, visit http://gerrit.cloudera.org:8080/18924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Gerrit-Change-Number: 18924
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [bootstrap] Reduce the memory size consumed when bootstrap
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18924
to look at the new patch set (#2).
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap
......................................................................
[bootstrap] Reduce the memory size consumed when bootstrap
When a tserver bootstrap, it will load all tablets metadata,
and will find out the maximum fs block id it seen to notify
the block manager to avoid generating duplicate ids.
However, a tablet may contains a large number of blocks,
that means it will consume a large amount of memory when
tablets parellel loaded when tserver bootstrap.
This patch optimize it to only find the maximum block id
of a tablet, instead of temporary store all block ids in
memory.
Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
---
M src/kudu/tablet/rowset_metadata.cc
M src/kudu/tablet/rowset_metadata.h
M src/kudu/tablet/tablet_metadata-test.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
5 files changed, 64 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/18924/2
--
To view, visit http://gerrit.cloudera.org:8080/18924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Gerrit-Change-Number: 18924
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [bootstrap] Reduce the memory size consumed when bootstrap
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18924 )
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Gerrit-Change-Number: 18924
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 13:10:05 +0000
Gerrit-HasComments: No
[kudu-CR] [bootstrap] Reduce the memory size consumed when bootstrap
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18924 )
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap
......................................................................
Patch Set 4:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@9
PS3, Line 9: bootstrap
> bootstraps
Done
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@9
PS3, Line 9: loads al
> loads
Done
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@10
PS3, Line 10: as seen
> it has seen
Done
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@10
PS3, Line 10: finds out
> finds
Done
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@12
PS3, Line 12: contain
> contain
Done
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@13
PS3, Line 13: consumes a l
> consumes
Done
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@15
PS3, Line 15:
: This patch optimizes the tablet bootstrap to find the
: maximu
> This patch optimizes the tablet bootstrap to find the maximum block id for
Done
http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/rowset_metadata.cc
File src/kudu/tablet/rowset_metadata.cc:
http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/rowset_metadata.cc@302
PS3, Line 302: BlockIdContainer blocks;
> nit: since you have touched this code, would you mind adding 'blocks.reserv
Done
http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/tablet_metadata-test.cc
File src/kudu/tablet/tablet_metadata-test.cc:
http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/tablet_metadata-test.cc@248
PS3, Line 248: TabletMetadata::kNoMrsFlushed));
> Wrap this into ASSERT_OK()?
Done
http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/tablet_metadata-test.cc@253
PS3, Line 253: const auto expected_max_block_id = std::max_element(block_ids.begin(), block_ids.end());
: ASSERT_EQ(*expected_max_block_id, max_block_id);
: }
:
> nit: is it possible to add a copy/move constructor for BlockId() and shorte
Good idea! Done
If using std::max_element instead of std::max, it's not needed to add a copy/move constructor.
--
To view, visit http://gerrit.cloudera.org:8080/18924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Gerrit-Change-Number: 18924
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 05:53:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [bootstrap] Reduce the memory size consumed when bootstrap
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18924
to look at the new patch set (#4).
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap
......................................................................
[bootstrap] Reduce the memory size consumed when bootstrap
When a tserver bootstraps, it loads all tablets metadata,
and finds out the maximum fs block id it has seen to notify
the block manager to avoid generating duplicate ids.
However, a tablet may contain a large number of blocks,
that means it consumes a large amount of memory when
tablets parellel loaded when tserver bootstrap.
This patch optimizes the tablet bootstrap to find the
maximum block id for a tablet without storing all the
block identifiers in the memory.
Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
---
M src/kudu/tablet/rowset_metadata.cc
M src/kudu/tablet/rowset_metadata.h
M src/kudu/tablet/tablet_metadata-test.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
5 files changed, 71 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/18924/4
--
To view, visit http://gerrit.cloudera.org:8080/18924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Gerrit-Change-Number: 18924
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [bootstrap] Reduce the memory size consumed when bootstrap
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18924 )
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@15
PS3, Line 15: This patch optimize it to only find the maximum block id
: of a tablet, instead of temporary store all block ids in
: memory
> This patch optimizes the tablet bootstrap to find the maximum block id for
This patch optimizes the tablet bootstrap to find the maximum block id for a tablet without storing all the block identifiers in the memory
--
To view, visit http://gerrit.cloudera.org:8080/18924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Gerrit-Change-Number: 18924
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 17:46:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [bootstrap] Reduce the memory size consumed when bootstrap
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18924 )
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap
......................................................................
[bootstrap] Reduce the memory size consumed when bootstrap
When a tserver bootstraps, it loads all tablets metadata,
and finds out the maximum fs block id it has seen to notify
the block manager to avoid generating duplicate ids.
However, a tablet may contain a large number of blocks,
that means it consumes a large amount of memory when
tablets parellel loaded when tserver bootstrap.
This patch optimizes the tablet bootstrap to find the
maximum block id for a tablet without storing all the
block identifiers in the memory.
Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Reviewed-on: http://gerrit.cloudera.org:8080/18924
Tested-by: Yingchun Lai <ac...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tablet/rowset_metadata.cc
M src/kudu/tablet/rowset_metadata.h
M src/kudu/tablet/tablet_metadata-test.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
5 files changed, 71 insertions(+), 16 deletions(-)
Approvals:
Yingchun Lai: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Gerrit-Change-Number: 18924
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [bootstrap] Reduce the memory size consumed when bootstrap
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18924 )
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap
......................................................................
Patch Set 3: Code-Review+1
(10 comments)
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@9
PS3, Line 9: bootstrap
bootstraps
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@9
PS3, Line 9: will load
loads
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@10
PS3, Line 10: will find
finds
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@10
PS3, Line 10: it seen
it has seen
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@12
PS3, Line 12: contains
contain
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@13
PS3, Line 13: will consume
consumes
http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@15
PS3, Line 15: This patch optimize it to only find the maximum block id
: of a tablet, instead of temporary store all block ids in
: memory
This patch optimizes the tablet bootstrap to find the maximum block id for a tablet without storing all the blocks in the memory.
http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/rowset_metadata.cc
File src/kudu/tablet/rowset_metadata.cc:
http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/rowset_metadata.cc@302
PS3, Line 302: BlockIdContainer blocks;
nit: since you have touched this code, would you mind adding 'blocks.reserve(...)' to avoid multiple re-allocations for the 'blocks' vector?
http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/tablet_metadata-test.cc
File src/kudu/tablet/tablet_metadata-test.cc:
http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/tablet_metadata-test.cc@248
PS3, Line 248: tablet_meta->UpdateAndFlush(RowSetMetadataIds(), rs_metas, TabletMetadata::kNoMrsFlushed);
Wrap this into ASSERT_OK()?
http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/tablet_metadata-test.cc@253
PS3, Line 253: BlockId expect_max_block_id;
: for (const auto& block_id : block_ids) {
: expect_max_block_id = std::max(expect_max_block_id, block_id);
: }
nit: is it possible to add a copy/move constructor for BlockId() and shorten this into:
const auto expected_max_block_id = std::max(block_ids.begin(), block_ids.end());
?
Using the std::max() algorithm might also help with more concise code in the newly introduced method RowSetMetadata::GetMaxLiveBlockId()
--
To view, visit http://gerrit.cloudera.org:8080/18924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Gerrit-Change-Number: 18924
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 17:45:45 +0000
Gerrit-HasComments: Yes
[kudu-CR] [bootstrap] Reduce the memory size consumed when bootstrap
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496
Gerrit-Change-Number: 18924
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>