You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2023/05/10 08:02:17 UTC

[GitHub] [skywalking-grafana-plugins] wu-sheng commented on a diff in pull request #1: build(ci): update yaml for checking license

wu-sheng commented on code in PR #1:
URL: https://github.com/apache/skywalking-grafana-plugins/pull/1#discussion_r1189507622


##########
.github/workflows/nodejs.yml:
##########
@@ -60,3 +68,12 @@ jobs:
 
       - name: Stop grafana docker
         run: docker-compose down
+        env:
+            CI: true
+  build:
+    runs-on: ubuntu-latest
+    timeout-minutes: 90
+    needs: [yarn]

Review Comment:
   ```suggestion
       needs: [yarn, check-license]
   ```
   
   Do we need this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org