[GitHub] [druid] gianm commented on a change in pull request #9545: SQL support for joins on subqueries.

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #9545: SQL support for joins on subqueries.
URL: https://github.com/apache/druid/pull/9545#discussion_r395918968
 
 

 ##########
 File path: sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQueryRel.java
 ##########
 @@ -34,22 +34,14 @@
 import org.apache.druid.java.util.common.guava.Sequence;
 import org.apache.druid.sql.calcite.table.DruidTable;
 
-import javax.annotation.Nonnull;
 import java.util.Set;
 
 /**
  * DruidRel that operates on top of a {@link DruidTable} directly (no joining or subqueries).
  */
 public class DruidQueryRel extends DruidRel<DruidQueryRel>
 {
-  // Factors used for computing cost (see computeSelfCost). These are intended to encourage pushing down filters
-  // and limits through stacks of nested queries when possible.
-  private static final double COST_BASE = 1.0;
-  private static final double COST_PER_COLUMN = 0.001;
-  private static final double COST_FILTER_MULTIPLIER = 0.1;
-  private static final double COST_GROUPING_MULTIPLIER = 0.5;
-  private static final double COST_LIMIT_MULTIPLIER = 0.5;
-  private static final double COST_HAVING_MULTIPLIER = 5.0;
+  static final double COST_BASE = 1.0;
 
 Review comment:
   Thanks, I'll remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org