You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by georgekankava <gi...@git.apache.org> on 2016/06/21 08:41:30 UTC
[GitHub] accumulo pull request #116: Multiple code improvements - squid:CommentedOutC...
GitHub user georgekankava opened a pull request:
https://github.com/apache/accumulo/pull/116
Multiple code improvements - squid:CommentedOutCodeLine, squid:MissingDeprecatedCheck, squid:S1165, squid:S1854
This pull request is focused on resolving occurrences of Sonar rules
squid:CommentedOutCodeLine - Sections of code should not be "commented out".
squid:MissingDeprecatedCheck - Deprecated elements should have both the annotation and the Javadoc tag.
squid:S1165 - Exception classes should be immutable.
squid:S1854 - Dead stores should be removed.
This pull request removes technical debt of 115 minutes.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine
https://dev.eclipse.org/sonar/rules/show/squid:MissingDeprecatedCheck
https://dev.eclipse.org/sonar/rules/show/squid:S1165
https://dev.eclipse.org/sonar/rules/show/squid:S1854
Please let me know if you have any questions.
George Kankava
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DevFactory/accumulo release/multiple-code-improvements-fix-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #116: Multiple code improvements - squid:CommentedOutCodeLine...
Posted by georgekankava <gi...@git.apache.org>.
Github user georgekankava commented on the issue:
https://github.com/apache/accumulo/pull/116
Same comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #116: Multiple code improvements - squid:CommentedOutC...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/116#discussion_r67888650
--- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/OfflineIterator.java ---
@@ -211,7 +211,7 @@ public boolean hasNext() {
private void nextTablet() throws TableNotFoundException, AccumuloException, IOException {
- Range nextRange = null;
--- End diff --
This is unnecessary to change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #116: Multiple code improvements - squid:CommentedOutC...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/116#discussion_r67899359
--- Diff: core/src/main/java/org/apache/accumulo/core/client/IsolatedScanner.java ---
@@ -247,6 +247,9 @@ public void setTimeOut(int timeOut) {
setTimeout(timeOut, TimeUnit.SECONDS);
}
+ /**
+ * @deprecated
--- End diff --
The javadoc tool is smart enough to identify Deprecated annotations. The addition of a javadoc tag for deprecation does nothing, unless there is a comment associated with it to explain the deprecation details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #116: Multiple code improvements - squid:CommentedOutC...
Posted by georgekankava <gi...@git.apache.org>.
Github user georgekankava closed the pull request at:
https://github.com/apache/accumulo/pull/116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---