You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2011/10/29 06:01:31 UTC

[Bug 6422] $VERSION = 'bogus'; is bad.

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422

--- Comment #1 from Kevin A. McGrail <km...@pccc.com> 2011-10-29 04:01:31 UTC ---
Created attachment 4996
  --> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4996
Patch to change $VERSION in a few pm's and sa-update

lib/Mail/SpamAssassin/Dns.pm:
  $VERSION = 'bogus';     # avoid CPAN.pm picking up razor ver
lib/Mail/SpamAssassin/Plugin.pm:
  $VERSION =              'bogus';
lib/Mail/SpamAssassin/Reporter.pm:
  $VERSION = 'bogus';   # avoid CPAN.pm picking up razor ver
lib/Mail/SpamAssassin/Conf.pm:
  $VERSION = 'bogus';     # avoid CPAN.pm picking up version strings later
lib/Mail/SpamAssassin/PluginHandler.pm:
  $VERSION = 'bogus';     # avoid CPAN.pm picking up version strings later

I propose removing all of the VERSION lines as the words "bogus" appear to
exist to "fix" a cpan issue that now breaks things.

Additionaly, I've changed sa-update.raw's VERSION to a call to
&Mail::SpamAssassin::version() as shown in the attached patch.

We can then see what happens when we upload 3.4.0 rc1 to CPAN.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.