You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "thetumbled (via GitHub)" <gi...@apache.org> on 2023/05/25 06:35:32 UTC
[GitHub] [pulsar] thetumbled opened a new pull request, #20396: [Fix] [Txn] unwrap the completion exception.
thetumbled opened a new pull request, #20396:
URL: https://github.com/apache/pulsar/pull/20396
<!-- Either this PR fixes an issue, -->
Fixes #20395
### Motivation
org.apache.pulsar.broker.TransactionMetadataStoreService#handleTcClientConnect

The real cause may be wrapped in the CompletionException, we should unwrap the real cause from CompletionException and complete the request with real causes like this:
<img width="550" alt="image" src="https://github.com/apache/pulsar/assets/52550727/bc0b3f5c-4379-4acf-9995-ec2de4ef5b6b">
### Modifications
unwrap the completion exception to retrieve real cause.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #20396: [Fix] [Txn] unwrap the completion exception.
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #20396:
URL: https://github.com/apache/pulsar/pull/20396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20396: [Fix] [Txn] unwrap the completion exception.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20396:
URL: https://github.com/apache/pulsar/pull/20396#issuecomment-1567664495
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20396?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20396](https://app.codecov.io/gh/apache/pulsar/pull/20396?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1325983) into [master](https://app.codecov.io/gh/apache/pulsar/commit/e4f1f095fef7e105cb7a3c5a1a8c2f9449888052?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e4f1f09) will **increase** coverage by `36.10%`.
> The diff coverage is `0.00%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20396 +/- ##
=============================================
+ Coverage 36.80% 72.91% +36.10%
- Complexity 12046 31892 +19846
=============================================
Files 1687 1864 +177
Lines 128755 138417 +9662
Branches 14002 15188 +1186
=============================================
+ Hits 47389 100927 +53538
+ Misses 75106 29471 -45635
- Partials 6260 8019 +1759
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.20% <0.00%> (+0.02%)` | :arrow_up: |
| systests | `24.92% <0.00%> (+0.04%)` | :arrow_up: |
| unittests | `72.18% <0.00%> (+40.18%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pulsar/broker/TransactionMetadataStoreService.java](https://app.codecov.io/gh/apache/pulsar/pull/20396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9UcmFuc2FjdGlvbk1ldGFkYXRhU3RvcmVTZXJ2aWNlLmphdmE=) | `68.06% <0.00%> (+19.54%)` | :arrow_up: |
... and [1433 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org