You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2018/11/18 03:31:17 UTC
[Impala-ASF-CR] IMPALA-5031: Extra large shifts are undefined behavior
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11951
Change subject: IMPALA-5031: Extra large shifts are undefined behavior
......................................................................
IMPALA-5031: Extra large shifts are undefined behavior
According to [expr.shift] in the C++14 standard, an expression in
which the shift value is "greater than or equal to the length in bits
of the promoted left operand" has undefined behavior.
Change-Id: Ie9cec6b2a887e62da594975bc971d38c1d38b0a0
---
M be/src/util/bit-packing-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/11951/1
--
To view, visit http://gerrit.cloudera.org:8080/11951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9cec6b2a887e62da594975bc971d38c1d38b0a0
Gerrit-Change-Number: 11951
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-5031: Extra large shifts are undefined behavior
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11951 )
Change subject: IMPALA-5031: Extra large shifts are undefined behavior
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9cec6b2a887e62da594975bc971d38c1d38b0a0
Gerrit-Change-Number: 11951
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Dec 2018 03:55:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Extra large shifts are undefined behavior
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11951 )
Change subject: IMPALA-5031: Extra large shifts are undefined behavior
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3535/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9cec6b2a887e62da594975bc971d38c1d38b0a0
Gerrit-Change-Number: 11951
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Dec 2018 00:11:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Extra large shifts are undefined behavior
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11951 )
Change subject: IMPALA-5031: Extra large shifts are undefined behavior
......................................................................
IMPALA-5031: Extra large shifts are undefined behavior
According to [expr.shift] in the C++14 standard, an expression in
which the shift value is "greater than or equal to the length in bits
of the promoted left operand" has undefined behavior.
Change-Id: Ie9cec6b2a887e62da594975bc971d38c1d38b0a0
Reviewed-on: http://gerrit.cloudera.org:8080/11951
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/bit-packing-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jim Apple: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9cec6b2a887e62da594975bc971d38c1d38b0a0
Gerrit-Change-Number: 11951
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5031: Extra large shifts are undefined behavior
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11951 )
Change subject: IMPALA-5031: Extra large shifts are undefined behavior
......................................................................
Patch Set 2: Code-Review+2
Carry Tim's
--
To view, visit http://gerrit.cloudera.org:8080/11951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9cec6b2a887e62da594975bc971d38c1d38b0a0
Gerrit-Change-Number: 11951
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Dec 2018 19:40:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Extra large shifts are undefined behavior
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11951 )
Change subject: IMPALA-5031: Extra large shifts are undefined behavior
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9cec6b2a887e62da594975bc971d38c1d38b0a0
Gerrit-Change-Number: 11951
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Dec 2018 18:11:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Extra large shifts are undefined behavior
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11951 )
Change subject: IMPALA-5031: Extra large shifts are undefined behavior
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1392/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9cec6b2a887e62da594975bc971d38c1d38b0a0
Gerrit-Change-Number: 11951
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Nov 2018 04:08:20 +0000
Gerrit-HasComments: No