You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda <kk...@cloudera.com> on 2017/04/04 15:57:33 UTC
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/
-----------------------------------------------------------
(Updated April 4, 2017, 3:57 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
Changes
-------
Added missing changes.
Summary (updated)
-----------------
SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID
Bugs: SENTRY-1638
https://issues.apache.org/jira/browse/SENTRY-1638
Repository: sentry
Description (updated)
-------
UpdateD SQL script of MSentryPathChange table to add a column for notification ID. Wich include changes to jdo defination and also MSentryPermChange class.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2ad26de23757842111beb12b154e1562b
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
Diff: https://reviews.apache.org/r/58164/diff/2/
Changes: https://reviews.apache.org/r/58164/diff/1-2/
Testing
-------
Thanks,
kalyan kumar kalvagadda
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Hao Hao <ha...@cloudera.com>.
> On April 4, 2017, 4:40 p.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/58164/diff/2/?file=1684331#file1684331line1>
> >
> > Why create a new file for create notification id field inside PATHChange table? It should be ok to just add upon the 008-SENTRY-1569.xxx.sql as there is no release yet.
>
> kalyan kumar kalvagadda wrote:
> My assumtion was that, we maintain one file per change which is labled with the Jira id so that would have a track of every change and why. That way we can use all thse files while upgrading.
>
> Thought, adding this change to 008-SENTRY-1569.xxx.sql would mix-up things.
Ok, but I am not sure if there is any impact for upgrade by doing in this way.
- Hao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review170981
-----------------------------------------------------------
On April 4, 2017, 5:05 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 5:05 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID. Wich include changes to jdo defination and also MSentryPermChange class.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On April 4, 2017, 4:40 p.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/58164/diff/2/?file=1684331#file1684331line1>
> >
> > Why create a new file for create notification id field inside PATHChange table? It should be ok to just add upon the 008-SENTRY-1569.xxx.sql as there is no release yet.
My assumtion was that, we maintain one file per change which is labled with the Jira id so that would have a track of every change and why. That way we can use all thse files while upgrading.
Thought, adding this change to 008-SENTRY-1569.xxx.sql would mix-up things.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review170981
-----------------------------------------------------------
On April 4, 2017, 5:05 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 5:05 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID. Wich include changes to jdo defination and also MSentryPermChange class.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Na Li <li...@cloudera.com>.
> On April 4, 2017, 4:40 p.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/58164/diff/2/?file=1684331#file1684331line1>
> >
> > Why create a new file for create notification id field inside PATHChange table? It should be ok to just add upon the 008-SENTRY-1569.xxx.sql as there is no release yet.
>
> kalyan kumar kalvagadda wrote:
> My assumtion was that, we maintain one file per change which is labled with the Jira id so that would have a track of every change and why. That way we can use all thse files while upgrading.
>
> Thought, adding this change to 008-SENTRY-1569.xxx.sql would mix-up things.
>
> Hao Hao wrote:
> Ok, but I am not sure if there is any impact for upgrade by doing in this way.
How about using the same file, but add comments to indicate the Jira case number?
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review170981
-----------------------------------------------------------
On April 6, 2017, 1:38 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 1:38 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 84b7903857ba51badde8a769eae86219eeaf3dab
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 69865508103bb8b1dd6148aa48c616d4b683614f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 6a438ea847619af4d4d99d0fb99e036e55bf425f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql a9b7e2c48bb86bc0a81fad00d27387e26ef18c28
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
>
>
> Diff: https://reviews.apache.org/r/58164/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review170981
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql
Lines 1 (patched)
<https://reviews.apache.org/r/58164/#comment243815>
Why create a new file for create notification id field inside PATHChange table? It should be ok to just add upon the 008-SENTRY-1569.xxx.sql as there is no release yet.
- Hao Hao
On April 4, 2017, 3:57 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 3:57 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID. Wich include changes to jdo defination and also MSentryPermChange class.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2ad26de23757842111beb12b154e1562b
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On April 4, 2017, 4:33 p.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java
> > Line 30 (original), 30 (patched)
> > <https://reviews.apache.org/r/58164/diff/2/?file=1684326#file1684326line30>
> >
> > I don't think we need notification ID on PermChange table? Any reason to do otherwise?
I just tried to get the changes from Eddy's previous review. Just realized that they are not correct.
Actual changes that are needed to MSentryPathChange.java and package.jdo are already committed. I will revert the changes done for MSentryPermChange.java and package.jdo.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review170980
-----------------------------------------------------------
On April 6, 2017, 12:05 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 12:05 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review170980
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java
Line 30 (original), 30 (patched)
<https://reviews.apache.org/r/58164/#comment243813>
I don't think we need notification ID on PermChange table? Any reason to do otherwise?
- Hao Hao
On April 4, 2017, 3:57 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 3:57 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID. Wich include changes to jdo defination and also MSentryPermChange class.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2ad26de23757842111beb12b154e1562b
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review170983
-----------------------------------------------------------
- kalyan kumar kalvagadda
On April 4, 2017, 5:05 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 5:05 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID. Wich include changes to jdo defination and also MSentryPermChange class.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On April 4, 2017, 6:29 p.m., Alexander Kolbasov wrote:
> > For tables that are new in sentry-ha-redesign branch, shouldn't we just update the initial creation scripts rather then add new scripts to fix the tables?
If we need to that we need to move all the other commits done in sentry-ha-redesign branch into one file. we can do that as a seperate effort.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171008
-----------------------------------------------------------
On April 6, 2017, 12:05 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 12:05 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171008
-----------------------------------------------------------
For tables that are new in sentry-ha-redesign branch, shouldn't we just update the initial creation scripts rather then add new scripts to fix the tables?
- Alexander Kolbasov
On April 4, 2017, 5:05 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 5:05 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID. Wich include changes to jdo defination and also MSentryPermChange class.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On April 6, 2017, 12:01 a.m., Alexander Kolbasov wrote:
> > I don't see any changes to package.jdo announced at the header - are they missing?
Updated the header
> On April 6, 2017, 12:01 a.m., Alexander Kolbasov wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql
> > Line 204 (original), 204 (patched)
> > <https://reviews.apache.org/r/58164/diff/3/?file=1684428#file1684428line204>
> >
> > Why did you remove all the quotes?
Just to be inline with the syntax followed in the rest of the file.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171172
-----------------------------------------------------------
On April 6, 2017, 12:05 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 12:05 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171172
-----------------------------------------------------------
I don't see any changes to package.jdo announced at the header - are they missing?
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql
Line 204 (original), 204 (patched)
<https://reviews.apache.org/r/58164/#comment244055>
Why did you remove all the quotes?
- Alexander Kolbasov
On April 4, 2017, 5:05 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 5:05 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID. Wich include changes to jdo defination and also MSentryPermChange class.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171182
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On April 6, 2017, 12:05 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 12:05 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On April 6, 2017, 12:41 a.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql
> > Lines 5 (patched)
> > <https://reviews.apache.org/r/58164/diff/4/?file=1685758#file1685758line5>
> >
> > Am I missing something? why is still using 008-xxx here? :) Also, again same as Sasha pointed out, I would prefer not to usea seperate sql script file to update the new table no one is using yet.
> >
> > BTW, did you get a chance to verify those changes?
I have tested it against all 5 databases that sentry offically suppports.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171184
-----------------------------------------------------------
On April 7, 2017, 9:56 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 9:56 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 84b7903857ba51badde8a769eae86219eeaf3dab
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 69865508103bb8b1dd6148aa48c616d4b683614f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 6a438ea847619af4d4d99d0fb99e036e55bf425f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql a9b7e2c48bb86bc0a81fad00d27387e26ef18c28
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
>
>
> Diff: https://reviews.apache.org/r/58164/diff/7/
>
>
> Testing
> -------
>
> I have tested it against derby, oracle, postgres, mysql and db2.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171184
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql
Lines 5 (patched)
<https://reviews.apache.org/r/58164/#comment244064>
Am I missing something? why is still using 008-xxx here? :) Also, again same as Sasha pointed out, I would prefer not to usea seperate sql script file to update the new table no one is using yet.
BTW, did you get a chance to verify those changes?
- Hao Hao
On April 6, 2017, 12:35 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 12:35 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171237
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql
Lines 269 (patched)
<https://reviews.apache.org/r/58164/#comment244115>
If you are adding unique index here, you also need to change the jdo definition as I do not see it has this constraint.
- Hao Hao
On April 6, 2017, 2:17 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 2:17 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 84b7903857ba51badde8a769eae86219eeaf3dab
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 69865508103bb8b1dd6148aa48c616d4b683614f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 6a438ea847619af4d4d99d0fb99e036e55bf425f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql a9b7e2c48bb86bc0a81fad00d27387e26ef18c28
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
>
>
> Diff: https://reviews.apache.org/r/58164/diff/6/
>
>
> Testing
> -------
>
> I have tested it against derby, oracle, postgres, mysql and db2.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171847
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On April 7, 2017, 9:56 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 9:56 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 84b7903857ba51badde8a769eae86219eeaf3dab
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 69865508103bb8b1dd6148aa48c616d4b683614f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 6a438ea847619af4d4d99d0fb99e036e55bf425f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql a9b7e2c48bb86bc0a81fad00d27387e26ef18c28
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
>
>
> Diff: https://reviews.apache.org/r/58164/diff/7/
>
>
> Testing
> -------
>
> I have tested it against derby, oracle, postgres, mysql and db2.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171885
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On April 7, 2017, 9:56 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 9:56 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 84b7903857ba51badde8a769eae86219eeaf3dab
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 69865508103bb8b1dd6148aa48c616d4b683614f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 6a438ea847619af4d4d99d0fb99e036e55bf425f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql a9b7e2c48bb86bc0a81fad00d27387e26ef18c28
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
>
>
> Diff: https://reviews.apache.org/r/58164/diff/7/
>
>
> Testing
> -------
>
> I have tested it against derby, oracle, postgres, mysql and db2.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/
-----------------------------------------------------------
(Updated April 7, 2017, 9:56 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
Changes
-------
Addressed Hao's review comment.
Bugs: SENTRY-1638
https://issues.apache.org/jira/browse/SENTRY-1638
Repository: sentry
Description
-------
UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f327346c09cdbe5785fb8824fc62e704
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 84b7903857ba51badde8a769eae86219eeaf3dab
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 69865508103bb8b1dd6148aa48c616d4b683614f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 6a438ea847619af4d4d99d0fb99e036e55bf425f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql a9b7e2c48bb86bc0a81fad00d27387e26ef18c28
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
Diff: https://reviews.apache.org/r/58164/diff/7/
Changes: https://reviews.apache.org/r/58164/diff/6-7/
Testing
-------
I have tested it against derby, oracle, postgres, mysql and db2.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/
-----------------------------------------------------------
(Updated April 6, 2017, 2:17 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
Changes
-------
Updated the test coverage.
Bugs: SENTRY-1638
https://issues.apache.org/jira/browse/SENTRY-1638
Repository: sentry
Description
-------
UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 84b7903857ba51badde8a769eae86219eeaf3dab
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 69865508103bb8b1dd6148aa48c616d4b683614f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 6a438ea847619af4d4d99d0fb99e036e55bf425f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql a9b7e2c48bb86bc0a81fad00d27387e26ef18c28
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
Diff: https://reviews.apache.org/r/58164/diff/6/
Testing (updated)
-------
I have tested it against derby, oracle, postgres, mysql and db2.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171013
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql
Line 51 (original), 51 (patched)
<https://reviews.apache.org/r/58164/#comment243846>
if you want to follow the same convention, need to remove the quote for table "SENTRY_PERM_CHANGE" as well
- Na Li
On April 6, 2017, 1:38 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 1:38 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 84b7903857ba51badde8a769eae86219eeaf3dab
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 69865508103bb8b1dd6148aa48c616d4b683614f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 6a438ea847619af4d4d99d0fb99e036e55bf425f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql a9b7e2c48bb86bc0a81fad00d27387e26ef18c28
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
>
>
> Diff: https://reviews.apache.org/r/58164/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/
-----------------------------------------------------------
(Updated April 6, 2017, 1:38 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
Changes
-------
Addressed hao's comment and avaoid using new sql script for upgrade purpose, instead updated the scripts where the table was actually created.
Bugs: SENTRY-1638
https://issues.apache.org/jira/browse/SENTRY-1638
Repository: sentry
Description
-------
UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 84b7903857ba51badde8a769eae86219eeaf3dab
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 69865508103bb8b1dd6148aa48c616d4b683614f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 6a438ea847619af4d4d99d0fb99e036e55bf425f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql a9b7e2c48bb86bc0a81fad00d27387e26ef18c28
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
Diff: https://reviews.apache.org/r/58164/diff/6/
Changes: https://reviews.apache.org/r/58164/diff/5-6/
Testing
-------
Thanks,
kalyan kumar kalvagadda
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/
-----------------------------------------------------------
(Updated April 6, 2017, 12:49 a.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
Changes
-------
Fixed the patch updated to review board.
Bugs: SENTRY-1638
https://issues.apache.org/jira/browse/SENTRY-1638
Repository: sentry
Description
-------
UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1638.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1638.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1638.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1638.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
Diff: https://reviews.apache.org/r/58164/diff/5/
Changes: https://reviews.apache.org/r/58164/diff/4-5/
Testing
-------
Thanks,
kalyan kumar kalvagadda
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/
-----------------------------------------------------------
(Updated April 6, 2017, 12:35 a.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
Changes
-------
Addressed Hao's comment.
Bugs: SENTRY-1638
https://issues.apache.org/jira/browse/SENTRY-1638
Repository: sentry
Description
-------
UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1638.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1638.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1638.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1638.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
Diff: https://reviews.apache.org/r/58164/diff/4/
Changes: https://reviews.apache.org/r/58164/diff/3-4/
Testing
-------
Thanks,
kalyan kumar kalvagadda
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/
-----------------------------------------------------------
(Updated April 6, 2017, 12:05 a.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
Changes
-------
Fixed the description.
Bugs: SENTRY-1638
https://issues.apache.org/jira/browse/SENTRY-1638
Repository: sentry
Description (updated)
-------
UpdateD SQL script of MSentryPathChange table to add a column for notification ID.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
Diff: https://reviews.apache.org/r/58164/diff/3/
Testing
-------
Thanks,
kalyan kumar kalvagadda
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On April 4, 2017, 6:14 p.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql
> > Lines 5 (patched)
> > <https://reviews.apache.org/r/58164/diff/3/?file=1684437#file1684437line5>
> >
> > Should it be 009-xxx other than 008-xxx if we want to have a seperate file for the change?
Should be fixed.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171003
-----------------------------------------------------------
On April 4, 2017, 5:05 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 5:05 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID. Wich include changes to jdo defination and also MSentryPermChange class.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review171003
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql
Lines 5 (patched)
<https://reviews.apache.org/r/58164/#comment243837>
Should it be 009-xxx other than 008-xxx if we want to have a seperate file for the change?
- Hao Hao
On April 4, 2017, 5:05 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58164/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 5:05 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
>
>
> Bugs: SENTRY-1638
> https://issues.apache.org/jira/browse/SENTRY-1638
>
>
> Repository: sentry
>
>
> Description
> -------
>
> UpdateD SQL script of MSentryPathChange table to add a column for notification ID. Wich include changes to jdo defination and also MSentryPermChange class.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
>
>
> Diff: https://reviews.apache.org/r/58164/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58164: SENTRY-1638 Update SQL script of
MSentryPathChange table to add a column for notification ID
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/
-----------------------------------------------------------
(Updated April 4, 2017, 5:05 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li.
Changes
-------
Addressed review comments.
Bugs: SENTRY-1638
https://issues.apache.org/jira/browse/SENTRY-1638
Repository: sentry
Description
-------
UpdateD SQL script of MSentryPathChange table to add a column for notification ID. Wich include changes to jdo defination and also MSentryPermChange class.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2fa1f02a4339e7af4bf45a169013e9ec65f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 547bbe8136186658e7fe76ab24934157ea5300ff
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a18ea59da28d3d7125cf227c7aaa7f7aa
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432db233ee4e7aa054adc1b82c26248a099
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f7cbd8f430733cb329e9fca263bda0f7
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53d7c468269ca2c41986ef8651b94f5c7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 5376c166659b3e8e373c8c20818f5b1290af90c9
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql dc3021a57ac9ea8145379c437ae6a94131c9ae5e
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql ef1c651da8998eb57b5d0ca3463317d07c1b3a24
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql f4a50de14dd0f961befaded394c6a01c2f459317
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql db010bcd7792c9370478a2061e22d14bb78e3184
Diff: https://reviews.apache.org/r/58164/diff/3/
Changes: https://reviews.apache.org/r/58164/diff/2-3/
Testing
-------
Thanks,
kalyan kumar kalvagadda