You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "exceptionfactory (via GitHub)" <gi...@apache.org> on 2025/09/09 19:53:13 UTC

[PR] NIFI-14947 Add Host Validation to StandardIssuerProvider [nifi]

exceptionfactory opened a new pull request, #10288:
URL: https://github.com/apache/nifi/pull/10288

   # Summary
   
   [NIFI-14947](https://issues.apache.org/jira/browse/NIFI-14947) Adds host validation to the `StandardIssuerProvider` and replaces invalid characters with the hyphen character to support creation of a valid URI.
   
   This change resolves test failures on GitHub macOS runners that can container the underscore character.
   
   Changes include a new unit test for `StandardIssuerProvider` to evaluate expected replacement behavior.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-14947 Add Host Validation to StandardIssuerProvider [nifi]

Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 closed pull request #10288: NIFI-14947 Add Host Validation to StandardIssuerProvider
URL: https://github.com/apache/nifi/pull/10288


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-14947 Add Host Validation to StandardIssuerProvider [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #10288:
URL: https://github.com/apache/nifi/pull/10288#issuecomment-3272244490

   The `ci-workflow` on macOS was a good test in this run because the host name shown in the System Information includes the invalid underscore character:
   
   ```
   sjc22-bt143_6446bae5-f567-4200-8cc2-d506627340ba-F2E3DC5A4772.local
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org