You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/05/29 05:36:42 UTC

[Bug 119480] New: Curve in Background cannot be displayed correctly in AOO3.4

https://issues.apache.org/ooo/show_bug.cgi?id=119480

          Priority: P3
            Bug ID: 119480
          Assignee: ooo-issues@incubator.apache.org
           Summary: Curve in Background cannot be displayed correctly in
                    AOO3.4
          Severity: normal
        Issue Type: DEFECT
    Classification: Application
                OS: All
          Reporter: bjdujing@gmail.com
          Hardware: PC
            Status: UNCONFIRMED
           Version: AOO 3.4.0
         Component: save-export
           Product: presentation

Created attachment 77675
  --> https://issues.apache.org/ooo/attachment.cgi?id=77675&action=edit
sample file

build:AOO3.4_1327774

Steps:
1.open the sample in AOO3.4 and switch to slide master view
2.check the slide background

defect:
Curve in Background cannot be displayed correctly in AOO3.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

--- Comment #2 from SunYing <su...@gmail.com> ---
root cause:
1.Open sample file with MS PPT 2003;
2.Enter the title master page view, select the object contain the curve;
3.Ungroup the object;
4.Find the curve autoshape isn't normal,which has been wrong processed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

Andre <af...@a-w-f.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78601|review?                     |review+
              Flags|                            |

--- Comment #15 from Andre <af...@a-w-f.de> ---
Comment on attachment 78601
  --> https://issues.apache.org/ooo/attachment.cgi?id=78601
patch for ppt import damaged curve error

Reviewed, OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

--- Comment #9 from SunYing <su...@gmail.com> ---
commets is very valuable.
and atan2 is a better choice^_^.
and in line 4558,the var fnumber should in [0,360].
change the code in the following:
   fNumber = atan2( double( aStartPt.X() - cent.X() ),double( aStartPt.Y() -   
cent.Y() ) )+ F_PI; // 0..2PI
   fNumber /= F_PI180; // 0..360.0
pls review.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

liupingtan <do...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

Andre <af...@a-w-f.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Andre <af...@a-w-f.de> ---
@SunYing: Thanks for your fix and your patience with my questions.

Committted with SVN revision 1359096.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

bjdujing@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1

--- Comment #3 from bjdujing@gmail.com ---
can reproduce in AOO 3.4,change confirm status

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

SunYing <su...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78571|                            |review?
              Flags|                            |

--- Comment #5 from SunYing <su...@gmail.com> ---
Created attachment 78571
  --> https://issues.apache.org/ooo/attachment.cgi?id=78571&action=edit
patch for ppt import damaged curve error

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

bjdujing@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Curve in Background cannot  |[From Symphony]Curve in
                   |be displayed correctly in   |Background cannot be
                   |AOO3.4                      |displayed correctly in
                   |                            |AOO3.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

liupingtan <do...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|VERIFIED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #19 from liupingtan <do...@gmail.com> ---
But still have a blue line in AOO ,no blue line in MS
refer capture.png

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

--- Comment #20 from liupingtan <do...@gmail.com> ---
Created attachment 79107
  --> https://issues.apache.org/ooo/attachment.cgi?id=79107&action=edit
Capture.png

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

--- Comment #11 from Andre <af...@a-w-f.de> ---
Thanks for the update, looks better now.  Just one more question.

There is a change on line 4520 (second hunk of the patch).  This changed from
the first version of the patch to the second version
from 

    if ( nNumElemVert >= 3 )

to

    if ( nNumElemVert >= 4 )

Which one is correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

--- Comment #21 from SunYing <su...@gmail.com> ---
I will  checking this issue again

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

Andre <af...@a-w-f.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78583|review?                     |
              Flags|                            |

--- Comment #14 from Andre <af...@a-w-f.de> ---
Comment on attachment 78583
  --> https://issues.apache.org/ooo/attachment.cgi?id=78583
patch for ppt import damaged curve error

Superseded by next patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

--- Comment #4 from SunYing <su...@gmail.com> ---
Created attachment 78570
  --> https://issues.apache.org/ooo/attachment.cgi?id=78570&action=edit
simple sample file which can reproduced this defect

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

SunYing <su...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78590|0                           |1
        is obsolete|                            |
  Attachment #78590|review?                     |
              Flags|                            |
  Attachment #78601|                            |review?
              Flags|                            |

--- Comment #12 from SunYing <su...@gmail.com> ---
Created attachment 78601
  --> https://issues.apache.org/ooo/attachment.cgi?id=78601&action=edit
patch for ppt import damaged curve error

if ( nNumElemVert >= 3 ) is correct, I created patch based on my old code.
update the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

SunYing <su...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sunyingshadesun@gmail.com

--- Comment #1 from SunYing <su...@gmail.com> ---
I'm checking this defect.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

SunYing <su...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78571|0                           |1
        is obsolete|                            |
  Attachment #78571|review?                     |
              Flags|                            |
  Attachment #78583|                            |review?
              Flags|                            |

--- Comment #7 from SunYing <su...@gmail.com> ---
Created attachment 78583
  --> https://issues.apache.org/ooo/attachment.cgi?id=78583&action=edit
patch for ppt import damaged curve error

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

Andre <af...@a-w-f.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |af@a-w-f.de

--- Comment #8 from Andre <af...@a-w-f.de> ---
Your patch looks basically good.

But I still have two questions:

- Regarding the use of atan() on line 4558:
  What do you thing about using atan2() instead?  That would allow detection of
the right quadrant.

- Regarding the call of NormAngle360() on line 4559:
  NormAngle360() seems to expect arguments that are given as angle, measured in
degree*100 (in the range [0,36000) for a full circle).
  In the patch, however, the argument is the result of atan()*100.  Atan()
returns a value in radian (range [-pi/2,+pi/2]).
  Is there a transformation factor missing (radian to degree) or am I missing
something?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

SunYing <su...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78590|                            |review?
              Flags|                            |

--- Comment #10 from SunYing <su...@gmail.com> ---
Created attachment 78590
  --> https://issues.apache.org/ooo/attachment.cgi?id=78590&action=edit
patch for ppt import damaged curve error

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

Li Feng Wang <ph...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #17 from Li Feng Wang <ph...@gmail.com> ---
look comment16, change status to reopened.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

Li Feng Wang <ph...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |phoenix.wanglf@gmail.com

--- Comment #16 from Li Feng Wang <ph...@gmail.com> ---
Verified on AOo trunk r1374181.
Curve in backgrond still not same as Curve in MS

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

--- Comment #6 from SunYing <su...@gmail.com> ---
solution:
Use the path data to calculate the start angle of special arc.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119480

liupingtan <do...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
                 CC|                            |doneyourself@gmail.com
         Resolution|---                         |FIXED

--- Comment #18 from liupingtan <do...@gmail.com> ---
Verified on Windows7-64bit &Ubuntu10.04 &Mac10.7 &Redhat &Ubuntu-64bit with AOO
trunk r1374181 ,Pass

-- 
You are receiving this mail because:
You are the assignee for the bug.