[GitHub] [arrow-datafusion] alamb commented on a change in pull request #2000: Fixed parquet path partitioning when only selecting partitioned columns

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #2000:
URL: https://github.com/apache/arrow-datafusion/pull/2000#discussion_r830593962



##########
File path: datafusion/src/physical_plan/file_format/parquet.rs
##########
@@ -446,6 +471,62 @@ fn build_row_group_predicate(
     }
 }
 
+fn read_partition_no_file_columns(

Review comment:
       I haven't looked carefully at this code, but it seems like this has a lot of duplication with `read_partition` -- I wonder if it is possible somehow to unify the code paths, perhaps by checking `projection.is_empty()` in `read_partition`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org