You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2012/03/19 18:43:37 UTC
[jira] [Created] (LUCENE-3885) smokeTestRelease.checkMaven should
not require a release branch
smokeTestRelease.checkMaven should not require a release branch
---------------------------------------------------------------
Key: LUCENE-3885
URL: https://issues.apache.org/jira/browse/LUCENE-3885
Project: Lucene - Java
Issue Type: Bug
Components: general/build
Reporter: Robert Muir
Currently this throws an exception, but I think it should unpack any pom templates it needs from the artifacts themselves.
# its nice to be able to generate and test RC's without having an official branch yet. I am currently doing this just to
move us closer to release (just trying to find bugs etc). Also anyone should be able to just toss up an RC at any time.
# its better to test the artifacts themselves rather than anything in SVN. At the least the -src jars have an svn export
so this should work... if it doesn't, then there is a packaging bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3885) smokeTestRelease.checkMaven should
not require a release branch
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233049#comment-13233049 ]
Steven Rowe commented on LUCENE-3885:
-------------------------------------
Committed to branch_3x and trunk
> smokeTestRelease.checkMaven should not require a release branch
> ---------------------------------------------------------------
>
> Key: LUCENE-3885
> URL: https://issues.apache.org/jira/browse/LUCENE-3885
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Robert Muir
> Attachments: LUCENE-3885.patch
>
>
> Currently this throws an exception, but I think it should unpack any pom templates it needs from the artifacts themselves.
> # its nice to be able to generate and test RC's without having an official branch yet. I am currently doing this just to
> move us closer to release (just trying to find bugs etc). Also anyone should be able to just toss up an RC at any time.
> # its better to test the artifacts themselves rather than anything in SVN. At the least the -src jars have an svn export
> so this should work... if it doesn't, then there is a packaging bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3885) smokeTestRelease.checkMaven should
not require a release branch
Posted by "Steven Rowe (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Rowe updated LUCENE-3885:
--------------------------------
Attachment: LUCENE-3885.patch
Fixes {{smokeTestRelease.py}} to refer to the local working copy if the RC URL supplied on the cmdline does not name a release branch.
Also, I commented out the check that Maven artifacts are exactly identical to their counterparts in the binary distribution.
Committing shortly.
> smokeTestRelease.checkMaven should not require a release branch
> ---------------------------------------------------------------
>
> Key: LUCENE-3885
> URL: https://issues.apache.org/jira/browse/LUCENE-3885
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Robert Muir
> Attachments: LUCENE-3885.patch
>
>
> Currently this throws an exception, but I think it should unpack any pom templates it needs from the artifacts themselves.
> # its nice to be able to generate and test RC's without having an official branch yet. I am currently doing this just to
> move us closer to release (just trying to find bugs etc). Also anyone should be able to just toss up an RC at any time.
> # its better to test the artifacts themselves rather than anything in SVN. At the least the -src jars have an svn export
> so this should work... if it doesn't, then there is a packaging bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3885) smokeTestRelease.checkMaven should
not require a release branch
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232785#comment-13232785 ]
Robert Muir commented on LUCENE-3885:
-------------------------------------
Also long term (not something we should tackle now!) I think it would be ideal if hudson somehow built
an actual release and smoketested-itself for our nightly build. This would make things a lot easier
and would ensure some things like packaging stay sane on an incremental basis (rather than doing a ton
of work at release time).
> smokeTestRelease.checkMaven should not require a release branch
> ---------------------------------------------------------------
>
> Key: LUCENE-3885
> URL: https://issues.apache.org/jira/browse/LUCENE-3885
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Robert Muir
>
> Currently this throws an exception, but I think it should unpack any pom templates it needs from the artifacts themselves.
> # its nice to be able to generate and test RC's without having an official branch yet. I am currently doing this just to
> move us closer to release (just trying to find bugs etc). Also anyone should be able to just toss up an RC at any time.
> # its better to test the artifacts themselves rather than anything in SVN. At the least the -src jars have an svn export
> so this should work... if it doesn't, then there is a packaging bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3885) smokeTestRelease.checkMaven should
not require a release branch
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232770#comment-13232770 ]
Robert Muir commented on LUCENE-3885:
-------------------------------------
Thanks Steven... hmm as a simple workaround can the smokeTester.py (which sits in dev-tools/scripts) just look for ../maven (from its own location as a reference)?
> smokeTestRelease.checkMaven should not require a release branch
> ---------------------------------------------------------------
>
> Key: LUCENE-3885
> URL: https://issues.apache.org/jira/browse/LUCENE-3885
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Robert Muir
>
> Currently this throws an exception, but I think it should unpack any pom templates it needs from the artifacts themselves.
> # its nice to be able to generate and test RC's without having an official branch yet. I am currently doing this just to
> move us closer to release (just trying to find bugs etc). Also anyone should be able to just toss up an RC at any time.
> # its better to test the artifacts themselves rather than anything in SVN. At the least the -src jars have an svn export
> so this should work... if it doesn't, then there is a packaging bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3885) smokeTestRelease.checkMaven should
not require a release branch
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232774#comment-13232774 ]
Steven Rowe commented on LUCENE-3885:
-------------------------------------
bq. as a simple workaround can the smokeTester.py (which sits in dev-tools/scripts) just look for ../maven (from its own location as a reference)?
Yes, I think that should work, but this should be done only if the release branch isn't available, since when there is a release branch, the likelihood of a mismatch between the local checkout and the release branch is higher.
> smokeTestRelease.checkMaven should not require a release branch
> ---------------------------------------------------------------
>
> Key: LUCENE-3885
> URL: https://issues.apache.org/jira/browse/LUCENE-3885
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Robert Muir
>
> Currently this throws an exception, but I think it should unpack any pom templates it needs from the artifacts themselves.
> # its nice to be able to generate and test RC's without having an official branch yet. I am currently doing this just to
> move us closer to release (just trying to find bugs etc). Also anyone should be able to just toss up an RC at any time.
> # its better to test the artifacts themselves rather than anything in SVN. At the least the -src jars have an svn export
> so this should work... if it doesn't, then there is a packaging bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3885) smokeTestRelease.checkMaven should
not require a release branch
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232771#comment-13232771 ]
Steven Rowe commented on LUCENE-3885:
-------------------------------------
Also, because of the way the POMs are structured, those that "aggregate" (recurse in sub-modules) but are not parents (e.g. the lucene and solr contrib POMs) are not released, since the release artifacts don't refer to them. Without them, it's impossible to tell which artifacts should be there.
> smokeTestRelease.checkMaven should not require a release branch
> ---------------------------------------------------------------
>
> Key: LUCENE-3885
> URL: https://issues.apache.org/jira/browse/LUCENE-3885
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Robert Muir
>
> Currently this throws an exception, but I think it should unpack any pom templates it needs from the artifacts themselves.
> # its nice to be able to generate and test RC's without having an official branch yet. I am currently doing this just to
> move us closer to release (just trying to find bugs etc). Also anyone should be able to just toss up an RC at any time.
> # its better to test the artifacts themselves rather than anything in SVN. At the least the -src jars have an svn export
> so this should work... if it doesn't, then there is a packaging bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3885) smokeTestRelease.checkMaven should
not require a release branch
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232767#comment-13232767 ]
Steven Rowe commented on LUCENE-3885:
-------------------------------------
In the past we've released with maven artifacts missing. That's why the svn check is done.
svn export excludes dev-tools, so the pom templates aren't available.
> smokeTestRelease.checkMaven should not require a release branch
> ---------------------------------------------------------------
>
> Key: LUCENE-3885
> URL: https://issues.apache.org/jira/browse/LUCENE-3885
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Robert Muir
>
> Currently this throws an exception, but I think it should unpack any pom templates it needs from the artifacts themselves.
> # its nice to be able to generate and test RC's without having an official branch yet. I am currently doing this just to
> move us closer to release (just trying to find bugs etc). Also anyone should be able to just toss up an RC at any time.
> # its better to test the artifacts themselves rather than anything in SVN. At the least the -src jars have an svn export
> so this should work... if it doesn't, then there is a packaging bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3885) smokeTestRelease.checkMaven should
not require a release branch
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232780#comment-13232780 ]
Robert Muir commented on LUCENE-3885:
-------------------------------------
ok, that makes sense to me. I agree the checker should try to avoid mismatches... but of course in general using an outdated
checker won't really work anyway for tons of possible reasons (i just updated the current one to reflect the new src tree structure).
> smokeTestRelease.checkMaven should not require a release branch
> ---------------------------------------------------------------
>
> Key: LUCENE-3885
> URL: https://issues.apache.org/jira/browse/LUCENE-3885
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Robert Muir
>
> Currently this throws an exception, but I think it should unpack any pom templates it needs from the artifacts themselves.
> # its nice to be able to generate and test RC's without having an official branch yet. I am currently doing this just to
> move us closer to release (just trying to find bugs etc). Also anyone should be able to just toss up an RC at any time.
> # its better to test the artifacts themselves rather than anything in SVN. At the least the -src jars have an svn export
> so this should work... if it doesn't, then there is a packaging bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3885) smokeTestRelease.checkMaven should
not require a release branch
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232778#comment-13232778 ]
Steven Rowe commented on LUCENE-3885:
-------------------------------------
bq. the likelihood of a mismatch between the local checkout and the release branch is higher
:) hmm, that's a bit obvious.... I just meant that relying on the local checkout could be problematic if it's not the same branch as the one over which the RC is being constructed.
> smokeTestRelease.checkMaven should not require a release branch
> ---------------------------------------------------------------
>
> Key: LUCENE-3885
> URL: https://issues.apache.org/jira/browse/LUCENE-3885
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Reporter: Robert Muir
>
> Currently this throws an exception, but I think it should unpack any pom templates it needs from the artifacts themselves.
> # its nice to be able to generate and test RC's without having an official branch yet. I am currently doing this just to
> move us closer to release (just trying to find bugs etc). Also anyone should be able to just toss up an RC at any time.
> # its better to test the artifacts themselves rather than anything in SVN. At the least the -src jars have an svn export
> so this should work... if it doesn't, then there is a packaging bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org