[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1524: [CELEBORN-610][FLINK] Eliminate pluginconf and merge its content to CelebornConf.

["zhongqiangczq (via GitHub)" <gi...@apache.org>]

zhongqiangczq commented on code in PR #1524:
URL: https://github.com/apache/incubator-celeborn/pull/1524#discussion_r1211002383


##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/AbstractRemoteShuffleInputGateFactory.java:
##########
@@ -67,38 +64,30 @@ public abstract class AbstractRemoteShuffleInputGateFactory {
   protected CelebornConf celebornConf;
 
   public AbstractRemoteShuffleInputGateFactory(
-      Configuration flinkConf,
-      CelebornConf conf,
-      NetworkBufferPool networkBufferPool,
-      int networkBufferSize) {
+      CelebornConf conf, NetworkBufferPool networkBufferPool, int networkBufferSize) {
     this.celebornConf = conf;
-    long configuredMemorySize =
-        FlinkUtils.byteStringValueAsBytes(flinkConf, PluginConf.MEMORY_PER_INPUT_GATE);
-    long minConfiguredMemorySize =
-        FlinkUtils.byteStringValueAsBytes(flinkConf, PluginConf.MIN_MEMORY_PER_GATE);
+    long configuredMemorySize = celebornConf.memoryPerInputGate();

Review Comment:
   if we copy the configs from flinkConf to celebornConf, the flinkConf can be removed directly, otherwise the config value is setted in flinkConf not in celebornConf, so we can't get the real value setted by user.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org