You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "luigidemasi (via GitHub)" <gi...@apache.org> on 2023/08/22 09:48:54 UTC

[GitHub] [camel] luigidemasi commented on a diff in pull request #11165: CAMEL-19760: netty-http:prevent the usage of proxy protocol in produc…

luigidemasi commented on code in PR #11165:
URL: https://github.com/apache/camel/pull/11165#discussion_r1301382503


##########
components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpProducer.java:
##########
@@ -51,6 +53,10 @@ public NettyHttpProducer(NettyHttpEndpoint nettyEndpoint, NettyConfiguration con
 
     @Override
     protected void doInit() throws Exception {
+        if (isProxyProtocol()) {

Review Comment:
   > I wonder if this can this be checked in createProducer instead?
   yeah, it's better there. moved.
   > Also we do not log and throw exception, only throw exception
   ok, removed the log.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org