You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <de...@geronimo.apache.org> on 2004/11/19 07:46:33 UTC

[jira] Created: (GERONIMO-488) jetty dispatch handling doesn't set component context, tx, or security properly in geronimo

jetty dispatch handling doesn't set component context, tx, or security properly in geronimo
-------------------------------------------------------------------------------------------

         Key: GERONIMO-488
         URL: http://nagoya.apache.org/jira/browse/GERONIMO-488
     Project: Apache Geronimo
        Type: Bug
  Components: web  
    Versions: 1.0-M3    
    Reporter: David Jencks
 Assigned to: David Jencks 


Currently we are setting the component jndi context, the thread context classloader, and the security info per web app in the handle method of a web app context subclass.  This is wrong.  This handle method is only called once from the socket listener.  Dispatches to other servlets, in particular servlets in other web apps, do not go through this handle method again.  Therefore the component context, transaction context, classloader, and security context are still those of the first web app accessed.

The solution appears to be to remove this code from the handle method and put it in enterContextScope and exitContextScope, public methods of Jetty's HttpContext.  These methods are called by dispatchers when changing web apps.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (GERONIMO-488) jetty dispatch handling doesn't set component context, tx, or security properly in geronimo

Posted by "Greg Wilkins (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-488?page=history ]

Greg Wilkins reassigned GERONIMO-488:
-------------------------------------

    Assign To: Greg Wilkins  (was: David Jencks)

> jetty dispatch handling doesn't set component context, tx, or security properly in geronimo
> -------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-488
>          URL: http://issues.apache.org/jira/browse/GERONIMO-488
>      Project: Apache Geronimo
>         Type: Bug
>   Components: web
>     Versions: 1.0-M3
>     Reporter: David Jencks
>     Assignee: Greg Wilkins
>      Fix For: 1.0-M4

>
> Currently we are setting the component jndi context, the thread context classloader, and the security info per web app in the handle method of a web app context subclass.  This is wrong.  This handle method is only called once from the socket listener.  Dispatches to other servlets, in particular servlets in other web apps, do not go through this handle method again.  Therefore the component context, transaction context, classloader, and security context are still those of the first web app accessed.
> The solution appears to be to remove this code from the handle method and put it in enterContextScope and exitContextScope, public methods of Jetty's HttpContext.  These methods are called by dispatchers when changing web apps.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-488) jetty dispatch handling doesn't set component context, tx, or security properly in geronimo

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://nagoya.apache.org/jira/browse/GERONIMO-488?page=history ]
     
David Jencks closed GERONIMO-488:
---------------------------------

     Resolution: Fixed
    Fix Version: 1.0-M4

I've implemented an interceptor-like stack for these operations called from enterScope and leaveScope.

> jetty dispatch handling doesn't set component context, tx, or security properly in geronimo
> -------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-488
>          URL: http://nagoya.apache.org/jira/browse/GERONIMO-488
>      Project: Apache Geronimo
>         Type: Bug
>   Components: web
>     Versions: 1.0-M3
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M4

>
> Currently we are setting the component jndi context, the thread context classloader, and the security info per web app in the handle method of a web app context subclass.  This is wrong.  This handle method is only called once from the socket listener.  Dispatches to other servlets, in particular servlets in other web apps, do not go through this handle method again.  Therefore the component context, transaction context, classloader, and security context are still those of the first web app accessed.
> The solution appears to be to remove this code from the handle method and put it in enterContextScope and exitContextScope, public methods of Jetty's HttpContext.  These methods are called by dispatchers when changing web apps.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (GERONIMO-488) jetty dispatch handling doesn't set component context, tx, or security properly in geronimo

Posted by "Greg Wilkins (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-488?page=history ]

Greg Wilkins reassigned GERONIMO-488:
-------------------------------------

    Assign To: David Jencks  (was: Greg Wilkins)

oops wrong issue

> jetty dispatch handling doesn't set component context, tx, or security properly in geronimo
> -------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-488
>          URL: http://issues.apache.org/jira/browse/GERONIMO-488
>      Project: Apache Geronimo
>         Type: Bug
>   Components: web
>     Versions: 1.0-M3
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M4

>
> Currently we are setting the component jndi context, the thread context classloader, and the security info per web app in the handle method of a web app context subclass.  This is wrong.  This handle method is only called once from the socket listener.  Dispatches to other servlets, in particular servlets in other web apps, do not go through this handle method again.  Therefore the component context, transaction context, classloader, and security context are still those of the first web app accessed.
> The solution appears to be to remove this code from the handle method and put it in enterContextScope and exitContextScope, public methods of Jetty's HttpContext.  These methods are called by dispatchers when changing web apps.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira