You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/17 06:15:12 UTC

[GitHub] eric-haibin-lin commented on a change in pull request #13419: [MXNET-1233] Enable dynamic shape in CachedOp

eric-haibin-lin commented on a change in pull request #13419: [MXNET-1233] Enable dynamic shape in CachedOp
URL: https://github.com/apache/incubator-mxnet/pull/13419#discussion_r242034481
 
 

 ##########
 File path: src/imperative/imperative_utils.h
 ##########
 @@ -1002,6 +1009,18 @@ void RunGraph(const bool retain_graph,
               const DispatchModeVector &dispatch_modes,
               bool recording);
 
+
+void NaiveRunGraph(const bool retain_graph,
 
 Review comment:
   I think these new functions deserve documentations for inputs/outputs and what it does to keep the readability 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services