[GitHub] [accumulo] ctubbsii commented on pull request #1656: Check if retries is set to 0 before retrying. #1655

[GitBox <gi...@apache.org>]

ctubbsii commented on pull request #1656:
URL: https://github.com/apache/accumulo/pull/1656#issuecomment-665405809


   @friedlou What does this change accomplish? There is no description of the change that helps us understand what it is trying to accomplish. From what I can tell, the most obvious consequence is fewer log messages: one for all failures, rather than individual messages for each failure in the loop that is skipped later, perhaps? I'm not sure that's much of an improvement, especially since, as @milleruntime says, it only affects the legacy bulk import. Am I missing something? Is there another benefit to this change?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org