[GitHub] mdindoffer opened a new pull request #322: Migrate to Files.new* creation of I/O streams during IDE boot

[GitBox <gi...@apache.org>]

mdindoffer opened a new pull request #322: Migrate to Files.new* creation of I/O streams during IDE boot
URL: https://github.com/apache/incubator-netbeans/pull/322
 
 
   This change drops the usage of FileInputStream and FileOutputStream in classes that affect the boot up of the IDE in order to help relieve the pressure on the GC via circumventing the finalization.
   
   I've measured the most notable offenders during the boot to reside in core, bootstrap and openide.filesystems modules:
   ![allocationhs_fis](https://user-images.githubusercontent.com/12681399/33808173-1e8ce318-dde2-11e7-8252-6b904bc60243.png)
   ![allocationhs_fos](https://user-images.githubusercontent.com/12681399/33808174-22e3e15a-dde2-11e7-9996-b182d1ad54d7.png)
   
   However, the **vastly** more prominent and omnipresent case of finalizable input streams can be observed in the ZipFileInputStreams originating from ZipFile and JarFile objects:
   ![allocationhs_zipfis](https://user-images.githubusercontent.com/12681399/33808237-3fd9bffe-dde3-11e7-815e-f921351a3860.png)
   As far as I know, there's no trivial solution to resolve those finalizations, but will look around for possible improvements there. 
   
   As for the GC performance, I've repeatedly measured very small improvements in the GC invocations with default JVM settings:
   Vanilla - http://gceasy.io/diamondgc-report.jsp?oTxnId_value=43107dc9-d949-4990-8585-684685aa4d02
   PR - http://gceasy.io/diamondgc-report.jsp?oTxnId_value=3c5f83a2-05d6-4edf-9719-35d5fd14ff6c
   The improvements are rather small, but please do note the measurements were taken on a new fairly powerful desktop PC with clean NB builds (zero projects imported, etc...). Therefore the gain might be bigger on lower end machines, where NB might be run (e.g. local schools?) or during real life usage scenarios. I encourage such tests, if in doubt.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services