You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/10/09 07:22:16 UTC

[GitHub] [zeppelin] Reamer opened a new pull request #3937: [ZEPPELIN-5089] ExecutorService shutdown

Reamer opened a new pull request #3937:
URL: https://github.com/apache/zeppelin/pull/3937


   ### What is this PR for?
   Included in this PR:
    - shutdown LifecylceManager
    - Shutdown the ParallelScheduler-Worker tasks
    - Use Initialization-on-demand_holder_idiom to create `SchedulerFactory` and `ExecutorFactory` singleton
    - Shutdown all scheduler tasks, when destroying the `SchedulerFactory`
    - Soft shutdown of ExecutorService with utility class `ExecutorUtil`
   
   ### What type of PR is it?
    - Improvement
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5089
   
   ### How should this be tested?
   * Travis-CI: https://travis-ci.org/github/Reamer/zeppelin/builds/734198773
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #3937: [ZEPPELIN-5089] ExecutorService shutdown

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3937:
URL: https://github.com/apache/zeppelin/pull/3937#issuecomment-708431165


   LGTM, thanks @Reamer 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #3937: [ZEPPELIN-5089] ExecutorService shutdown

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3937:
URL: https://github.com/apache/zeppelin/pull/3937#issuecomment-708444200


   Thanks for your review. If there are no further comments, I will merge this PR into Master and Branch-0.9 on Friday (16.10.2020)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #3937: [ZEPPELIN-5089] ExecutorService shutdown

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3937:
URL: https://github.com/apache/zeppelin/pull/3937


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #3937: [ZEPPELIN-5089] ExecutorService shutdown

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3937:
URL: https://github.com/apache/zeppelin/pull/3937#issuecomment-708303863


   @zjffdu This changes are ready for review.
   I need these changes to complete https://github.com/apache/zeppelin/pull/3925


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org