[jira] [Commented] (JENA-1344) Transactions - begin(WRITE);end() should throw an excepotion.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JENA-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024944#comment-16024944 ] 

ASF GitHub Bot commented on JENA-1344:
--------------------------------------

GitHub user afs opened a pull request:

    https://github.com/apache/jena/pull/252

    JENA-1344: Exception on begin(W)-end without commit or abort.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afs/jena jena-1344_txn-write-end

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #252
    
----
commit 106af3a05b0c5bfbe03eb3be32ba3992ec0b06b9
Author: Andy Seaborne <an...@apache.org>
Date:   2017-05-25T15:57:41Z

    JENA-1344: Exception on begin(W)-end without commit or abort.

----


> Transactions - begin(WRITE);end() should throw an excepotion.
> -------------------------------------------------------------
>
>                 Key: JENA-1344
>                 URL: https://issues.apache.org/jira/browse/JENA-1344
>             Project: Apache Jena
>          Issue Type: Bug
>    Affects Versions: Jena 3.3.0
>            Reporter: Andy Seaborne
>            Assignee: Andy Seaborne
>             Fix For: Jena 3.4.0
>
>
> Currently, it logs a warning, and does a silent abort.  Instead, it should abort and then throw an exception - no data is being committed without inspecting logs, it looks like the transaction was OK when in fact it wasn't.
> {noformat}
>     public static void main(String... args) {
>         //DatasetGraph dsg = DatasetGraphFactory.createTxnMem();
>         DatasetGraph dsg = TDBFactory.createDatasetGraph();
>         
>         dsg.begin(ReadWrite.WRITE);
>         dsg.end();
>         System.out.println("DONE");
>         System.exit(0);
>     }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)