[GitHub] [incubator-superset] rusackas commented on a change in pull request #11090: refactor: Replace react-bootstrap tabs with Antd tabs

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #11090:
URL: https://github.com/apache/incubator-superset/pull/11090#discussion_r497653524



##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -18,18 +18,19 @@
  */
 import React from 'react';
 import PropTypes from 'prop-types';
-import { MenuItem, DropdownButton, Tab, Tabs } from 'react-bootstrap';
+import { EditableTabs } from 'src/common/components/Tabs';
+import { Dropdown } from 'src/common/components/Dropdown';

Review comment:
       Nice! A new component has entered the game! Might be nice to see a screenshot of this on the PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org