[GitHub] [spark] szehon-ho commented on a diff in pull request #41683: [SPARK-36680][SQL] Supports Dynamic Table Options for Spark SQL

["szehon-ho (via GitHub)" <gi...@apache.org>]

szehon-ho commented on code in PR #41683:
URL: https://github.com/apache/spark/pull/41683#discussion_r1289355058


##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -3250,6 +3250,43 @@ class DataSourceV2SQLSuiteV1Filter
     }
   }
 
+  test("SPARK-36680: Supports Dynamic Table Options for Spark SQL") {
+    val t1 = s"${catalogAndNamespace}table"
+    withTable(t1) {
+      sql(s"CREATE TABLE $t1 (id bigint, data string) USING $v2Format")
+      sql(s"INSERT INTO $t1 VALUES (1, 'a'), (2, 'b')")
+
+      val df = sql(s"SELECT * FROM with_options('$t1', map('foo','bar'))")

Review Comment:
   Done, let me know if its better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org