You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Jia Zhai <zh...@apache.org> on 2017/12/11 09:51:51 UTC
[VOTE] Apache BookKeeper Release 4.6.0, release candidate #1
Hi everyone,
Please review and vote on the release candidate #1 for the version
4.6.0, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* Release notes [1]
* The official Apache source and binary distributions to be deployed
to dist.apache.org [2]
* All artifacts to be deployed to the Maven Central Repository [3]
* Source code tag "release-4.6.0" [4]
BookKeeper's KEYS file contains PGP keys we used to sign this
release:https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
Please download these packages and review this release candidate:
- Review release notes
- Download the source package (verify md5, shasum, and asc) and follow the
instructions to build and run the bookkeeper service.
- Download the binary package (verify md5, shasum, and asc) and follow the
instructions to run the bookkeeper service.
- Review maven repo, release tag, licenses, and any other things you think
it is important to a release.
The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
Thanks,
Jia Zhai
[1] *https://github.com/apache/bookkeeper/pull/759
<https://github.com/apache/bookkeeper/pull/759>*
[2] *https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.0-rc1/
<https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.0-rc1/>*
[3]
https://repository.apache.org/content/repositories/orgapachebookkeeper-1022/
[4] https://github.com/apache/bookkeeper/tree/release-4.6.0
Re: [VOTE] Apache BookKeeper Release 4.6.0, release candidate #1
Posted by Sijie Guo <gu...@gmail.com>.
+1 (binding)
1) notices, licenses look good to me (I can be biased since I made that
change)
2) md5, signature look good
3) binary package looks good (run standalone)
4) source package looks good (compile, test and run standalone)
5) artifactory, tag look good
Environment: OSX
On Tue, Dec 12, 2017 at 4:14 AM, Enrico Olivelli <eo...@gmail.com>
wrote:
> 2017-12-11 10:51 GMT+01:00 Jia Zhai <zh...@apache.org>:
>
> > Hi everyone,
> >
> > Please review and vote on the release candidate #1 for the version
> > 4.6.0, as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed
> > to dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "release-4.6.0" [4]
> >
> > BookKeeper's KEYS file contains PGP keys we used to sign this
> > release:https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify md5, shasum, and asc) and follow
> the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify md5, shasum, and asc) and follow
> the
> > instructions to run the bookkeeper service.
> > - Review maven repo, release tag, licenses, and any other things you
> think
> > it is important to a release.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> >
> +1 (non binding)
> 1) ran build and unit tests from source package
> 2) run tests on some projects (like HerdDB and Majordodo) (using maven
> artifacts built from the sources above)
> 3) run bookie sanity tests using a single bookie from the server binary
> package built from the sources above)
>
> As already reported there are some Backward Compatiblity issues but they
> are noted in the release notes
> There is some known flaky test, already noted.
>
> Thank you Jia
> Enrico
>
>
>
> > Thanks,
> > Jia Zhai
> >
> > [1] *https://github.com/apache/bookkeeper/pull/759
> > <https://github.com/apache/bookkeeper/pull/759>*
> > [2] *https://dist.apache.org/repos/dist/dev/bookkeeper/
> > bookkeeper-4.6.0-rc1/
> > <https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.0-rc1/
> >*
> > [3]
> > https://repository.apache.org/content/repositories/
> > orgapachebookkeeper-1022/
> > [4] https://github.com/apache/bookkeeper/tree/release-4.6.0
> >
>
Re: [VOTE] Apache BookKeeper Release 4.6.0, release candidate #1
Posted by Enrico Olivelli <eo...@gmail.com>.
2017-12-11 10:51 GMT+01:00 Jia Zhai <zh...@apache.org>:
> Hi everyone,
>
> Please review and vote on the release candidate #1 for the version
> 4.6.0, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed
> to dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "release-4.6.0" [4]
>
> BookKeeper's KEYS file contains PGP keys we used to sign this
> release:https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify md5, shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify md5, shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review maven repo, release tag, licenses, and any other things you think
> it is important to a release.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
>
+1 (non binding)
1) ran build and unit tests from source package
2) run tests on some projects (like HerdDB and Majordodo) (using maven
artifacts built from the sources above)
3) run bookie sanity tests using a single bookie from the server binary
package built from the sources above)
As already reported there are some Backward Compatiblity issues but they
are noted in the release notes
There is some known flaky test, already noted.
Thank you Jia
Enrico
> Thanks,
> Jia Zhai
>
> [1] *https://github.com/apache/bookkeeper/pull/759
> <https://github.com/apache/bookkeeper/pull/759>*
> [2] *https://dist.apache.org/repos/dist/dev/bookkeeper/
> bookkeeper-4.6.0-rc1/
> <https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.0-rc1/>*
> [3]
> https://repository.apache.org/content/repositories/
> orgapachebookkeeper-1022/
> [4] https://github.com/apache/bookkeeper/tree/release-4.6.0
>
Re: [VOTE] Apache BookKeeper Release 4.6.0, release candidate #1
Posted by Ivan Kelly <iv...@apache.org>.
Yup,
Check how spark do it:
http://apache.rediris.es/spark/spark-2.2.1/spark-2.2.1-bin-hadoop2.7.tgz
-Ivan
On Thu, Dec 14, 2017 at 3:57 PM, Ivan Kelly <iv...@apache.org> wrote:
> Will check. New BSD is pretty explicit about this though.
>
> 2. Redistributions in binary form must reproduce the above copyright
> notice, this list of conditions and the following disclaimer in the
> documentation and/or other materials provided with the distribution.
>
> -Ivan
>
> On Thu, Dec 14, 2017 at 3:54 PM, Sijie Guo <gu...@gmail.com> wrote:
>> Can you check what other scala projects do regarding the LICENCE files,
>> regarding scala license? How do their LICENCE files look like?
>>
>> Sijie
>>
>> On Dec 14, 2017 4:07 AM, "Ivan Kelly" <iv...@apache.org> wrote:
>>
>>> -1 (binding)
>>>
>>> I really hate to do this again. I had everything checked out, and
>>> everything was good. RAT, findbugs, tests (though there was a few
>>> flakes, these are fixed in master), jepsen passed, notice files were
>>> good. I was writing the +1 email, and typing that I had checked
>>> "NOTICES and LICENSE", and realized I hadn't checked the LICENSE
>>> files.
>>>
>>> In the LICENSE files we have licenses and copyright notices for SLF4J
>>> and Protobuf, these are required by the "New BSD License". We have
>>> since added two new New BSD jars, ParaNamer & Scala. Also, Java
>>> Servlet is under CDDL. I'm not sure if CDDL requires the same as New
>>> BSD and MIT.
>>>
>>> So, really sorry, but it has to be -1 again :(
>>>
>>> I'll make a PR this afternoon to fix the issues.
>>>
>>> -Ivan
>>>
>>>
>>>
>>> On Mon, Dec 11, 2017 at 10:51 AM, Jia Zhai <zh...@apache.org> wrote:
>>> > Hi everyone,
>>> >
>>> > Please review and vote on the release candidate #1 for the version
>>> > 4.6.0, as follows:
>>> > [ ] +1, Approve the release
>>> > [ ] -1, Do not approve the release (please provide specific comments)
>>> >
>>> > The complete staging area is available for your review, which includes:
>>> > * Release notes [1]
>>> > * The official Apache source and binary distributions to be deployed
>>> > to dist.apache.org [2]
>>> > * All artifacts to be deployed to the Maven Central Repository [3]
>>> > * Source code tag "release-4.6.0" [4]
>>> >
>>> > BookKeeper's KEYS file contains PGP keys we used to sign this
>>> > release:https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>>> >
>>> > Please download these packages and review this release candidate:
>>> >
>>> > - Review release notes
>>> > - Download the source package (verify md5, shasum, and asc) and follow
>>> the
>>> > instructions to build and run the bookkeeper service.
>>> > - Download the binary package (verify md5, shasum, and asc) and follow
>>> the
>>> > instructions to run the bookkeeper service.
>>> > - Review maven repo, release tag, licenses, and any other things you
>>> think
>>> > it is important to a release.
>>> >
>>> > The vote will be open for at least 72 hours. It is adopted by majority
>>> > approval, with at least 3 PMC affirmative votes.
>>> >
>>> > Thanks,
>>> > Jia Zhai
>>> >
>>> > [1] *https://github.com/apache/bookkeeper/pull/759
>>> > <https://github.com/apache/bookkeeper/pull/759>*
>>> > [2] *https://dist.apache.org/repos/dist/dev/bookkeeper/
>>> bookkeeper-4.6.0-rc1/
>>> > <https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.0-rc1/
>>> >*
>>> > [3]
>>> > https://repository.apache.org/content/repositories/
>>> orgapachebookkeeper-1022/
>>> > [4] https://github.com/apache/bookkeeper/tree/release-4.6.0
>>>
Re: [VOTE] Apache BookKeeper Release 4.6.0, release candidate #1
Posted by Ivan Kelly <iv...@apache.org>.
Will check. New BSD is pretty explicit about this though.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
-Ivan
On Thu, Dec 14, 2017 at 3:54 PM, Sijie Guo <gu...@gmail.com> wrote:
> Can you check what other scala projects do regarding the LICENCE files,
> regarding scala license? How do their LICENCE files look like?
>
> Sijie
>
> On Dec 14, 2017 4:07 AM, "Ivan Kelly" <iv...@apache.org> wrote:
>
>> -1 (binding)
>>
>> I really hate to do this again. I had everything checked out, and
>> everything was good. RAT, findbugs, tests (though there was a few
>> flakes, these are fixed in master), jepsen passed, notice files were
>> good. I was writing the +1 email, and typing that I had checked
>> "NOTICES and LICENSE", and realized I hadn't checked the LICENSE
>> files.
>>
>> In the LICENSE files we have licenses and copyright notices for SLF4J
>> and Protobuf, these are required by the "New BSD License". We have
>> since added two new New BSD jars, ParaNamer & Scala. Also, Java
>> Servlet is under CDDL. I'm not sure if CDDL requires the same as New
>> BSD and MIT.
>>
>> So, really sorry, but it has to be -1 again :(
>>
>> I'll make a PR this afternoon to fix the issues.
>>
>> -Ivan
>>
>>
>>
>> On Mon, Dec 11, 2017 at 10:51 AM, Jia Zhai <zh...@apache.org> wrote:
>> > Hi everyone,
>> >
>> > Please review and vote on the release candidate #1 for the version
>> > 4.6.0, as follows:
>> > [ ] +1, Approve the release
>> > [ ] -1, Do not approve the release (please provide specific comments)
>> >
>> > The complete staging area is available for your review, which includes:
>> > * Release notes [1]
>> > * The official Apache source and binary distributions to be deployed
>> > to dist.apache.org [2]
>> > * All artifacts to be deployed to the Maven Central Repository [3]
>> > * Source code tag "release-4.6.0" [4]
>> >
>> > BookKeeper's KEYS file contains PGP keys we used to sign this
>> > release:https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>> >
>> > Please download these packages and review this release candidate:
>> >
>> > - Review release notes
>> > - Download the source package (verify md5, shasum, and asc) and follow
>> the
>> > instructions to build and run the bookkeeper service.
>> > - Download the binary package (verify md5, shasum, and asc) and follow
>> the
>> > instructions to run the bookkeeper service.
>> > - Review maven repo, release tag, licenses, and any other things you
>> think
>> > it is important to a release.
>> >
>> > The vote will be open for at least 72 hours. It is adopted by majority
>> > approval, with at least 3 PMC affirmative votes.
>> >
>> > Thanks,
>> > Jia Zhai
>> >
>> > [1] *https://github.com/apache/bookkeeper/pull/759
>> > <https://github.com/apache/bookkeeper/pull/759>*
>> > [2] *https://dist.apache.org/repos/dist/dev/bookkeeper/
>> bookkeeper-4.6.0-rc1/
>> > <https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.0-rc1/
>> >*
>> > [3]
>> > https://repository.apache.org/content/repositories/
>> orgapachebookkeeper-1022/
>> > [4] https://github.com/apache/bookkeeper/tree/release-4.6.0
>>
Re: [VOTE] Apache BookKeeper Release 4.6.0, release candidate #1
Posted by Sijie Guo <gu...@gmail.com>.
Can you check what other scala projects do regarding the LICENCE files,
regarding scala license? How do their LICENCE files look like?
Sijie
On Dec 14, 2017 4:07 AM, "Ivan Kelly" <iv...@apache.org> wrote:
> -1 (binding)
>
> I really hate to do this again. I had everything checked out, and
> everything was good. RAT, findbugs, tests (though there was a few
> flakes, these are fixed in master), jepsen passed, notice files were
> good. I was writing the +1 email, and typing that I had checked
> "NOTICES and LICENSE", and realized I hadn't checked the LICENSE
> files.
>
> In the LICENSE files we have licenses and copyright notices for SLF4J
> and Protobuf, these are required by the "New BSD License". We have
> since added two new New BSD jars, ParaNamer & Scala. Also, Java
> Servlet is under CDDL. I'm not sure if CDDL requires the same as New
> BSD and MIT.
>
> So, really sorry, but it has to be -1 again :(
>
> I'll make a PR this afternoon to fix the issues.
>
> -Ivan
>
>
>
> On Mon, Dec 11, 2017 at 10:51 AM, Jia Zhai <zh...@apache.org> wrote:
> > Hi everyone,
> >
> > Please review and vote on the release candidate #1 for the version
> > 4.6.0, as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed
> > to dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "release-4.6.0" [4]
> >
> > BookKeeper's KEYS file contains PGP keys we used to sign this
> > release:https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify md5, shasum, and asc) and follow
> the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify md5, shasum, and asc) and follow
> the
> > instructions to run the bookkeeper service.
> > - Review maven repo, release tag, licenses, and any other things you
> think
> > it is important to a release.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Jia Zhai
> >
> > [1] *https://github.com/apache/bookkeeper/pull/759
> > <https://github.com/apache/bookkeeper/pull/759>*
> > [2] *https://dist.apache.org/repos/dist/dev/bookkeeper/
> bookkeeper-4.6.0-rc1/
> > <https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.0-rc1/
> >*
> > [3]
> > https://repository.apache.org/content/repositories/
> orgapachebookkeeper-1022/
> > [4] https://github.com/apache/bookkeeper/tree/release-4.6.0
>
Re: [VOTE] Apache BookKeeper Release 4.6.0, release candidate #1
Posted by Ivan Kelly <iv...@apache.org>.
-1 (binding)
I really hate to do this again. I had everything checked out, and
everything was good. RAT, findbugs, tests (though there was a few
flakes, these are fixed in master), jepsen passed, notice files were
good. I was writing the +1 email, and typing that I had checked
"NOTICES and LICENSE", and realized I hadn't checked the LICENSE
files.
In the LICENSE files we have licenses and copyright notices for SLF4J
and Protobuf, these are required by the "New BSD License". We have
since added two new New BSD jars, ParaNamer & Scala. Also, Java
Servlet is under CDDL. I'm not sure if CDDL requires the same as New
BSD and MIT.
So, really sorry, but it has to be -1 again :(
I'll make a PR this afternoon to fix the issues.
-Ivan
On Mon, Dec 11, 2017 at 10:51 AM, Jia Zhai <zh...@apache.org> wrote:
> Hi everyone,
>
> Please review and vote on the release candidate #1 for the version
> 4.6.0, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed
> to dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "release-4.6.0" [4]
>
> BookKeeper's KEYS file contains PGP keys we used to sign this
> release:https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify md5, shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify md5, shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review maven repo, release tag, licenses, and any other things you think
> it is important to a release.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Jia Zhai
>
> [1] *https://github.com/apache/bookkeeper/pull/759
> <https://github.com/apache/bookkeeper/pull/759>*
> [2] *https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.0-rc1/
> <https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.0-rc1/>*
> [3]
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1022/
> [4] https://github.com/apache/bookkeeper/tree/release-4.6.0