You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bh...@apache.org on 2015/06/15 11:28:22 UTC
[1/4] git commit: updated refs/heads/master to 34a791c
Repository: cloudstack
Updated Branches:
refs/heads/master 0f4aac735 -> 34a791c29
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineDataCenterVO.java Assert isn't used in prod runtime, null is checked in method
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
This closes #447
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/1b79a8e1
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/1b79a8e1
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/1b79a8e1
Branch: refs/heads/master
Commit: 1b79a8e1d64cb998a44e07a58c1f13b64eed97fe
Parents: 0f4aac7
Author: Rafael da Fonseca <rs...@gmail.com>
Authored: Sun Jun 14 21:28:48 2015 +0200
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Mon Jun 15 12:24:04 2015 +0300
----------------------------------------------------------------------
.../engine/datacenter/entity/api/db/EngineDataCenterVO.java | 2 --
1 file changed, 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/1b79a8e1/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineDataCenterVO.java
----------------------------------------------------------------------
diff --git a/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineDataCenterVO.java b/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineDataCenterVO.java
index 82b6150..ca9ad50 100644
--- a/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineDataCenterVO.java
+++ b/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineDataCenterVO.java
@@ -402,8 +402,6 @@ public class EngineDataCenterVO implements EngineDataCenter, Identity {
}
public String getDetail(String name) {
- assert (details != null) : "Did you forget to load the details?";
-
return details != null ? details.get(name) : null;
}
[4/4] git commit: updated refs/heads/master to 34a791c
Posted by bh...@apache.org.
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in UserVmJoinVO.java Assert isn't used in prod runtime
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
This closes #455
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/34a791c2
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/34a791c2
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/34a791c2
Branch: refs/heads/master
Commit: 34a791c295e7ff7805c5b43a90bd31dd0426fc8c
Parents: 874aa8d
Author: Rafael da Fonseca <rs...@gmail.com>
Authored: Sun Jun 14 21:47:54 2015 +0200
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Mon Jun 15 12:28:05 2015 +0300
----------------------------------------------------------------------
server/src/com/cloud/api/query/vo/UserVmJoinVO.java | 2 --
1 file changed, 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/34a791c2/server/src/com/cloud/api/query/vo/UserVmJoinVO.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/api/query/vo/UserVmJoinVO.java b/server/src/com/cloud/api/query/vo/UserVmJoinVO.java
index 633d01b..54a48fb 100644
--- a/server/src/com/cloud/api/query/vo/UserVmJoinVO.java
+++ b/server/src/com/cloud/api/query/vo/UserVmJoinVO.java
@@ -747,8 +747,6 @@ public class UserVmJoinVO extends BaseViewVO implements ControlledViewEntity {
}
public String getDetail(String name) {
- assert (details != null) : "Did you forget to load the details?";
-
return details != null ? details.get(name) : null;
}
[2/4] git commit: updated refs/heads/master to 34a791c
Posted by bh...@apache.org.
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in NetworkOrchestrator.java If answer is null, method will throw ConnectionException in line 3016 as satisfied by condition stated in line 3014
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
This closes #449
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/0dc25905
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/0dc25905
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/0dc25905
Branch: refs/heads/master
Commit: 0dc25905d2eda8f5539960d381e1d9af7bf30982
Parents: 1b79a8e
Author: Rafael da Fonseca <rs...@gmail.com>
Authored: Sun Jun 14 21:36:11 2015 +0200
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Mon Jun 15 12:27:54 2015 +0300
----------------------------------------------------------------------
.../cloudstack/engine/orchestration/NetworkOrchestrator.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/0dc25905/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
----------------------------------------------------------------------
diff --git a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java b/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
index 6277df1..d4cdd9d 100644
--- a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
+++ b/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
@@ -3017,7 +3017,7 @@ public class NetworkOrchestrator extends ManagerBase implements NetworkOrchestra
}
if (!answer.getResult()) {
- s_logger.warn("Unable to setup agent " + hostId + " due to " + ((answer != null) ? answer.getDetails() : "return null"));
+ s_logger.warn("Unable to setup agent " + hostId + " due to " + answer.getDetails() );
String msg = "Incorrect Network setup on agent, Reinitialize agent after network names are setup, details : " + answer.getDetails();
_alertMgr.sendAlert(AlertManager.AlertType.ALERT_TYPE_HOST, dcId, host.getPodId(), msg, msg);
throw new ConnectionException(true, msg);
[3/4] git commit: updated refs/heads/master to 34a791c
Posted by bh...@apache.org.
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in HostVO.java Assert isn't used in prod runtime
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
This closes #451
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/874aa8d1
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/874aa8d1
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/874aa8d1
Branch: refs/heads/master
Commit: 874aa8d15a1f66e579a41a37c1d1841e8c7ef93a
Parents: 0dc2590
Author: Rafael da Fonseca <rs...@gmail.com>
Authored: Sun Jun 14 21:41:33 2015 +0200
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Mon Jun 15 12:28:00 2015 +0300
----------------------------------------------------------------------
engine/schema/src/com/cloud/host/HostVO.java | 2 --
1 file changed, 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/874aa8d1/engine/schema/src/com/cloud/host/HostVO.java
----------------------------------------------------------------------
diff --git a/engine/schema/src/com/cloud/host/HostVO.java b/engine/schema/src/com/cloud/host/HostVO.java
index 4af8fb7..c5938d6 100644
--- a/engine/schema/src/com/cloud/host/HostVO.java
+++ b/engine/schema/src/com/cloud/host/HostVO.java
@@ -296,8 +296,6 @@ public class HostVO implements Host {
}
public String getDetail(String name) {
- assert (details != null) : "Did you forget to load the details?";
-
return details != null ? details.get(name) : null;
}