You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Remko Popma (JIRA)" <ji...@apache.org> on 2018/05/18 02:06:00 UTC
[jira] [Comment Edited] (GROOVY-8567) Migrate Groovyc to picocli
[ https://issues.apache.org/jira/browse/GROOVY-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480015#comment-16480015 ]
Remko Popma edited comment on GROOVY-8567 at 5/18/18 2:05 AM:
--------------------------------------------------------------
Thanks for merging the PR!
About groovyc, I saw that on the master branch, there is an [additional commit|https://github.com/apache/groovy/commit/f03b04a77db26a9555dac46de7bd4dd4728d7fa9] that preserves methods {{generateCompilerConfigurationFromOptions (org.apache.commons.cli.CommandLine cli)}}, {{generateFileNamesFromOptions (org.apache.commons.cli.CommandLine cli)}} and {{createCompilationOptions() : Options}} to preserve binary compatibility.
However, I cannot see this additional commit on the 2.5.x and 2.6.x branches. Is that intentional, or should it be the other way around?
About -v and -V, it is probably best to be consistent across all tools in the Groovy toolchain.
Is now a good time to change grape to also use uppercase {{\-V}} for {{\--version}}? I believe this is the [unix convention|http://www.catb.org/esr/writings/taoup/html/ch10s05.html]. (Also it makes the code shorter because we can use {{mixinStandardHelpOptions=true}} instead of explicitly declaring a boolean field for the version, but that is an implementation detail...) If you don't like this idea we can change the {{groovyc}} command line handling to use {{\-V}} for version.
was (Author: remkop@yahoo.com):
Thanks for merging the PR!
About groovyc, I saw that on the master branch, there is an [additional commit|https://github.com/apache/groovy/commit/f03b04a77db26a9555dac46de7bd4dd4728d7fa9] that preserves methods {{generateCompilerConfigurationFromOptions (org.apache.commons.cli.CommandLine cli)}}, {{generateFileNamesFromOptions (org.apache.commons.cli.CommandLine cli)}} and {{createCompilationOptions() : Options}} to preserve binary compatibility.
However, I cannot see this additional commit on the 2.5.x and 2.6.x branches. Is that intentional, or should it be the other way around?
About -v and -V, it is probably best to be consistent across all tools in the Groovy toolchain.
Is now a good time to change grape to also use {{\-V}} for {{\--version}}? I believe this is the [unix convention|http://www.catb.org/esr/writings/taoup/html/ch10s05.html]. (Also it makes the code shorter because we can use {{mixinStandardHelpOptions=true}} instead of explicitly declaring a boolean field for the version, but that is an implementation detail...) If you don't like this idea we can change the {{groovyc}} command line handling to use {{\-V}} for version.
> Migrate Groovyc to picocli
> --------------------------
>
> Key: GROOVY-8567
> URL: https://issues.apache.org/jira/browse/GROOVY-8567
> Project: Groovy
> Issue Type: Task
> Components: command line processing
> Reporter: Remko Popma
> Assignee: Paul King
> Priority: Major
> Fix For: 2.5.0-rc-3
>
>
> Migrate {{org.codehaus.groovy.ant.Groovyc}} from commons-cli to picocli.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)