[GitHub] [druid] gianm commented on a change in pull request #10495: Added Request log updates for status change on cooridnator / overlord…

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #10495:
URL: https://github.com/apache/druid/pull/10495#discussion_r505343730



##########
File path: server/src/main/java/org/apache/druid/server/initialization/jetty/JettyRequestLog.java
##########
@@ -41,6 +45,20 @@ public void log(Request request, Response response)
           request.getHttpURI().toString(),
           request.getProtocol()
       );
+    } else if ((HttpMethod.POST.equals(request.getMethod())

Review comment:
       This is going to behave differently depending on whether debug logging is enabled or not. If debug is enabled, this code path won't execute, and _less_ information will get logged, and potentially at a lower level. This behavior doesn't really make sense.
   
   I'd suggest writing out what behavior change you're suggesting and why, so we can discuss that along with the code change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org