You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2016/02/23 15:21:27 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-350 fix for potential race
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/400
ARTEMIS-350 fix for potential race
It's possible for the latch used for flow control here to get out of sync. In
other words, multiple count-downs can occur between count-ups so that the latch
always has a count > 0. When this situation arises then every single packet
sent to the replica is delayed by 5 seconds.
The solution here essentially is to reset the latch back to zero every time
instead of decrementing it by one with a normal count-down. This should still
maintain overall flow-control, but also avoid this race condition.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-350
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/400.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #400
----
commit 366316352f1e0169effb1b455832a9188aed671c
Author: jbertram <jb...@apache.org>
Date: 2016-02-16T16:45:25Z
ARTEMIS-350 fix for potential race
It's possible for the latch used for flow control here to get out of sync. In
other words, multiple count-downs can occur between count-ups so that the latch
always has a count > 0. When this situation arises then every single packet
sent to the replica is delayed by 5 seconds.
The solution here essentially is to reset the latch back to zero every time
instead of decrementing it by one with a normal count-down. This should still
maintain overall flow-control, but also avoid this race condition.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-350 fix for potential race
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/400
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---