[jira] [Closed] (HUDI-299) Refactoring Hoodie#getFileName

["leesf (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HUDI-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

leesf closed HUDI-299.
----------------------
    Resolution: Not A Problem

> Refactoring Hoodie#getFileName
> ------------------------------
>
>                 Key: HUDI-299
>                 URL: https://issues.apache.org/jira/browse/HUDI-299
>             Project: Apache Hudi (incubating)
>          Issue Type: Improvement
>          Components: Common Core
>            Reporter: leesf
>            Assignee: leesf
>            Priority: Minor
>             Fix For: 0.5.1
>
>
> Currently, the code style used in HoodieInstance#getFileName is below.
> {code:java}
> if (xxx) {
>     return;
> } else if (xxx) {
>     return;
> } else if (xxx) {
>     return;
> }
> throw new IllegalArgumentException("xxx");
> {code}
> However, it could be refactored into a simpler and more readable code style.
> {code:java}
> if (xxx) {
>     return;
> } 
> if (xxx) {
>     return;
> } 
> if (xxx) {
>     return;
> }
> throw new IllegalArgumentException("xxx");
> {code}
> CC [~vbalaji] [~vinoth]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)