You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/20 03:38:03 UTC

[GitHub] [hbase] jatsakthi commented on a change in pull request #1174: HBASE-23827 [HBCK2] Add mergeRegions method to hbck service

jatsakthi commented on a change in pull request #1174: HBASE-23827 [HBCK2] Add mergeRegions method to hbck service
URL: https://github.com/apache/hbase/pull/1174#discussion_r381716030
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
 ##########
 @@ -2458,6 +2443,48 @@ public FileArchiveNotificationResponse reportFileArchival(RpcController controll
  
   // HBCK Services
 
+  @Override
+  public MergeTableRegionsResponse mergeRegions(RpcController c, MergeTableRegionsRequest request)
 
 Review comment:
   Thanks for your comment @wchevreuil . But shouldn't we be able to determine whether the request is coming in from hbck or regular client? because we want to do some extra steps in case of non-hbck generated request. Like calling cp hooks? or master initialization check? and our most recent HBASE-23864 which prevents us from submitting a merge regions procedure in case the split/merge switch is turned off? We wouldn't want hbck to adhere to split/merge switch rules right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services