You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Paul Lindner <li...@inuus.com> on 2011/06/08 02:43:33 UTC
Review Request: gjslint fixes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/859/
-----------------------------------------------------------
Review request for shindig, johnfargo and Michael Hermanto.
Summary
-------
mostly simple cleanups.. constants.js was heavily modified though...
Diffs
-----
/trunk/features/src/main/javascript/features/cloo/cloo.js 1133077
/trunk/features/src/main/javascript/features/container/constant.js 1133077
/trunk/features/src/main/javascript/features/container/gadget_holder.js 1133077
/trunk/features/src/main/javascript/features/container/gadget_site.js 1133077
/trunk/features/src/main/javascript/features/container/init.js 1133077
/trunk/features/src/main/javascript/features/container/service.js 1133077
/trunk/features/src/main/javascript/features/container/util.js 1133077
/trunk/features/src/main/javascript/features/core.config.base/config.js 1133077
/trunk/features/src/main/javascript/features/core.io/io.js 1133077
/trunk/features/src/main/javascript/features/osapi.base/batch.js 1133077
/trunk/features/src/main/javascript/features/osapi/jsonrpctransport.js 1133077
/trunk/features/src/main/javascript/features/rpc/flash.transport.js 1133077
/trunk/features/src/main/javascript/features/rpc/ifpc.transport.js 1133077
/trunk/features/src/main/javascript/features/rpc/rpc.js 1133077
/trunk/features/src/main/javascript/features/rpc/wpm.transport.js 1133077
Diff: https://reviews.apache.org/r/859/diff
Testing
-------
Thanks,
Paul
Re: Review Request: gjslint fixes
Posted by jo...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/859/#review780
-----------------------------------------------------------
Ship it!
- johnfargo
On 2011-06-08 00:43:33, Paul Lindner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/859/
> -----------------------------------------------------------
>
> (Updated 2011-06-08 00:43:33)
>
>
> Review request for shindig, johnfargo and Michael Hermanto.
>
>
> Summary
> -------
>
> mostly simple cleanups.. constants.js was heavily modified though...
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/cloo/cloo.js 1133077
> /trunk/features/src/main/javascript/features/container/constant.js 1133077
> /trunk/features/src/main/javascript/features/container/gadget_holder.js 1133077
> /trunk/features/src/main/javascript/features/container/gadget_site.js 1133077
> /trunk/features/src/main/javascript/features/container/init.js 1133077
> /trunk/features/src/main/javascript/features/container/service.js 1133077
> /trunk/features/src/main/javascript/features/container/util.js 1133077
> /trunk/features/src/main/javascript/features/core.config.base/config.js 1133077
> /trunk/features/src/main/javascript/features/core.io/io.js 1133077
> /trunk/features/src/main/javascript/features/osapi.base/batch.js 1133077
> /trunk/features/src/main/javascript/features/osapi/jsonrpctransport.js 1133077
> /trunk/features/src/main/javascript/features/rpc/flash.transport.js 1133077
> /trunk/features/src/main/javascript/features/rpc/ifpc.transport.js 1133077
> /trunk/features/src/main/javascript/features/rpc/rpc.js 1133077
> /trunk/features/src/main/javascript/features/rpc/wpm.transport.js 1133077
>
> Diff: https://reviews.apache.org/r/859/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul
>
>
Re: Review Request: gjslint fixes
Posted by Michael Hermanto <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/859/#review783
-----------------------------------------------------------
Ship it!
- Michael
On 2011-06-08 00:43:33, Paul Lindner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/859/
> -----------------------------------------------------------
>
> (Updated 2011-06-08 00:43:33)
>
>
> Review request for shindig, johnfargo and Michael Hermanto.
>
>
> Summary
> -------
>
> mostly simple cleanups.. constants.js was heavily modified though...
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/cloo/cloo.js 1133077
> /trunk/features/src/main/javascript/features/container/constant.js 1133077
> /trunk/features/src/main/javascript/features/container/gadget_holder.js 1133077
> /trunk/features/src/main/javascript/features/container/gadget_site.js 1133077
> /trunk/features/src/main/javascript/features/container/init.js 1133077
> /trunk/features/src/main/javascript/features/container/service.js 1133077
> /trunk/features/src/main/javascript/features/container/util.js 1133077
> /trunk/features/src/main/javascript/features/core.config.base/config.js 1133077
> /trunk/features/src/main/javascript/features/core.io/io.js 1133077
> /trunk/features/src/main/javascript/features/osapi.base/batch.js 1133077
> /trunk/features/src/main/javascript/features/osapi/jsonrpctransport.js 1133077
> /trunk/features/src/main/javascript/features/rpc/flash.transport.js 1133077
> /trunk/features/src/main/javascript/features/rpc/ifpc.transport.js 1133077
> /trunk/features/src/main/javascript/features/rpc/rpc.js 1133077
> /trunk/features/src/main/javascript/features/rpc/wpm.transport.js 1133077
>
> Diff: https://reviews.apache.org/r/859/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul
>
>