You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2015/12/17 03:38:37 UTC
Re: Review Request 41125: Unified Container: Changed docker store and
appc store to support passing runtime config to provisioner.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41125/
-----------------------------------------------------------
(Updated Dec. 16, 2015, 6:38 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-2980
https://issues.apache.org/jira/browse/MESOS-2980
Repository: mesos
Description
-------
Unified Container: Changed docker store and appc store to support passing runtime config to provisioner.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/appc/store.hpp b2a77802f49c76f36f49282c7c77dfa51a602a9a
src/slave/containerizer/mesos/provisioner/appc/store.cpp 439ae0eb804f8d50081015165e6f2eca28df520f
src/slave/containerizer/mesos/provisioner/docker/store.hpp e246a1460ecdf9855ccafb43379572425de4ffd3
src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c
src/slave/containerizer/mesos/provisioner/provisioner.hpp b5d40b9428c9aa2f397540ef275cca7a7a335e43
src/slave/containerizer/mesos/provisioner/provisioner.cpp 8a2c9bbf7e01a62ad92ba19216b32f6e813cd736
src/slave/containerizer/mesos/provisioner/store.hpp 8d1493856420dee3210af79b628c8c770c5c8550
src/tests/containerizer/provisioner_appc_tests.cpp 9c5d91ba1fd49602418a0dd7c26b3132d3ac1a68
src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2
src/tests/containerizer/store.hpp 0d2879602f01e3dfcc20d7f2272ea01e47729574
Diff: https://reviews.apache.org/r/41125/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 41125: Unified Container: Changed docker store and
appc store to support passing runtime config to provisioner.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41125/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 1:30 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-2980
https://issues.apache.org/jira/browse/MESOS-2980
Repository: mesos
Description
-------
Unified Container: Changed docker store and appc store to support passing runtime config to provisioner.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/appc/store.hpp b2a77802f49c76f36f49282c7c77dfa51a602a9a
src/slave/containerizer/mesos/provisioner/appc/store.cpp 439ae0eb804f8d50081015165e6f2eca28df520f
src/slave/containerizer/mesos/provisioner/docker/store.hpp e246a1460ecdf9855ccafb43379572425de4ffd3
src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c
src/slave/containerizer/mesos/provisioner/provisioner.hpp b5d40b9428c9aa2f397540ef275cca7a7a335e43
src/slave/containerizer/mesos/provisioner/provisioner.cpp 8a2c9bbf7e01a62ad92ba19216b32f6e813cd736
src/slave/containerizer/mesos/provisioner/store.hpp 8d1493856420dee3210af79b628c8c770c5c8550
src/tests/containerizer/provisioner_appc_tests.cpp 9c5d91ba1fd49602418a0dd7c26b3132d3ac1a68
src/tests/containerizer/provisioner_docker_tests.cpp b57ee8681e0861cf93f5dcf9368c004a57df1374
src/tests/containerizer/store.hpp 0d2879602f01e3dfcc20d7f2272ea01e47729574
Diff: https://reviews.apache.org/r/41125/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 41125: Unified Container: Changed docker store and
appc store to support passing runtime config to provisioner.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41125/#review110898
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Dec. 17, 2015, 2:38 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41125/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 2:38 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2980
> https://issues.apache.org/jira/browse/MESOS-2980
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Unified Container: Changed docker store and appc store to support passing runtime config to provisioner.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/appc/store.hpp b2a77802f49c76f36f49282c7c77dfa51a602a9a
> src/slave/containerizer/mesos/provisioner/appc/store.cpp 439ae0eb804f8d50081015165e6f2eca28df520f
> src/slave/containerizer/mesos/provisioner/docker/store.hpp e246a1460ecdf9855ccafb43379572425de4ffd3
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c
> src/slave/containerizer/mesos/provisioner/provisioner.hpp b5d40b9428c9aa2f397540ef275cca7a7a335e43
> src/slave/containerizer/mesos/provisioner/provisioner.cpp 8a2c9bbf7e01a62ad92ba19216b32f6e813cd736
> src/slave/containerizer/mesos/provisioner/store.hpp 8d1493856420dee3210af79b628c8c770c5c8550
> src/tests/containerizer/provisioner_appc_tests.cpp 9c5d91ba1fd49602418a0dd7c26b3132d3ac1a68
> src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2
> src/tests/containerizer/store.hpp 0d2879602f01e3dfcc20d7f2272ea01e47729574
>
> Diff: https://reviews.apache.org/r/41125/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>