You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2014/05/03 08:31:48 UTC
svn commit: r1592155 - in /pdfbox/branches/1.8:
fontbox/src/main/java/org/apache/fontbox/ttf/
pdfbox/src/main/java/org/apache/pdfbox/cos/
pdfbox/src/main/java/org/apache/pdfbox/pdfviewer/
pdfbox/src/main/java/org/apache/pdfbox/util/operator/pagedrawer/
Author: tilman
Date: Sat May 3 06:31:47 2014
New Revision: 1592155
URL: http://svn.apache.org/r1592155
Log:
PDFBOX-2054: replace printStackTrace() and System.out.println() with logging as suggested by Hong-Thai Nguyen
Modified:
pdfbox/branches/1.8/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java
pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/cos/COSString.java
pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfviewer/PageDrawer.java
pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/util/operator/pagedrawer/Invoke.java
Modified: pdfbox/branches/1.8/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java?rev=1592155&r1=1592154&r2=1592155&view=diff
==============================================================================
--- pdfbox/branches/1.8/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java (original)
+++ pdfbox/branches/1.8/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java Sat May 3 06:31:47 2014
@@ -19,6 +19,8 @@
package org.apache.fontbox.ttf;
import java.io.IOException;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
/**
* This class is based on code from Apache Batik a subproject of Apache XMLGraphics. see
@@ -27,6 +29,11 @@ import java.io.IOException;
public class GlyfSimpleDescript extends GlyfDescript
{
+ /**
+ * Log instance.
+ */
+ private static final Log LOG = LogFactory.getLog(GlyfSimpleDescript.class);
+
private int[] endPtsOfContours;
private byte[] flags;
private short[] xCoordinates;
@@ -197,7 +204,7 @@ public class GlyfSimpleDescript extends
}
catch (ArrayIndexOutOfBoundsException e)
{
- System.out.println("error: array index out of bounds");
+ LOG.error("error: array index out of bounds", e);
}
}
Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/cos/COSString.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/cos/COSString.java?rev=1592155&r1=1592154&r2=1592155&view=diff
==============================================================================
--- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/cos/COSString.java (original)
+++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/cos/COSString.java Sat May 3 06:31:47 2014
@@ -19,6 +19,8 @@ package org.apache.pdfbox.cos;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.OutputStream;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.apache.pdfbox.encoding.PdfDocEncoding;
import org.apache.pdfbox.exceptions.COSVisitorException;
@@ -33,6 +35,11 @@ import org.apache.pdfbox.persistence.uti
public class COSString extends COSBase
{
/**
+ * Log instance.
+ */
+ private static final Log LOG = LogFactory.getLog(COSString.class);
+
+ /**
* One of the open string tokens.
*/
public static final byte[] STRING_OPEN = new byte[] { 40 }; // "(".getBytes();
@@ -141,7 +148,7 @@ public class COSString extends COSBase
}
catch (IOException ignore)
{
- ignore.printStackTrace();
+ LOG.error(ignore,ignore);
// should never happen
}
}
@@ -161,7 +168,7 @@ public class COSString extends COSBase
}
catch (IOException ignore)
{
- ignore.printStackTrace();
+ LOG.error(ignore,ignore);
// should never happen
}
}
@@ -321,7 +328,7 @@ public class COSString extends COSBase
catch (IOException e)
{
// should never happen
- e.printStackTrace();
+ LOG.error (e,e);
retval = new String(getBytes());
}
this.str = retval;
Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfviewer/PageDrawer.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfviewer/PageDrawer.java?rev=1592155&r1=1592154&r2=1592155&view=diff
==============================================================================
--- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfviewer/PageDrawer.java (original)
+++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfviewer/PageDrawer.java Sat May 3 06:31:47 2014
@@ -257,7 +257,7 @@ public class PageDrawer extends PDFStrea
}
catch( IOException io )
{
- io.printStackTrace();
+ LOG.error (io, io);
}
}
Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/util/operator/pagedrawer/Invoke.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/util/operator/pagedrawer/Invoke.java?rev=1592155&r1=1592154&r2=1592155&view=diff
==============================================================================
--- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/util/operator/pagedrawer/Invoke.java (original)
+++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/util/operator/pagedrawer/Invoke.java Sat May 3 06:31:47 2014
@@ -110,7 +110,6 @@ public class Invoke extends OperatorProc
}
catch( Exception e )
{
- e.printStackTrace();
LOG.error(e, e);
}
}