You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/04/21 14:42:26 UTC
[GitHub] [bookkeeper] nicoloboschi opened a new pull request, #3234: Enable Netty and BookKeeper IO optimizations on jdk17
nicoloboschi opened a new pull request, #3234:
URL: https://github.com/apache/bookkeeper/pull/3234
### Motivation
Starting from JDK17 the reflection is not allowed in the jdk internals modules. Until JDK16, it will print a warning like this:
```
Error: WARNING: An illegal reflective access operation has occurred
Error: WARNING: Illegal reflective access by org.apache.bookkeeper.proto.checksum.DirectMemoryCRC32Digest (file:/home/runner/work/bookkeeper/bookkeeper/bookkeeper-server/target/classes/) to method java.util.zip.CRC32.updateByteBuffer(int,long,int,int)
Error: WARNING: Please consider reporting this to the maintainers of org.apache.bookkeeper.proto.checksum.DirectMemoryCRC32Digest
Error: WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
Error: WARNING: All illegal access operations will be denied in a future release
```
With JDK17, BookKeeper and Netty work well even if this optimization are not allowed. In order to continue to use them, we need to open the required modules
For Netty, we can follow this issue: https://github.com/netty/netty/issues/12265
For BookKeeper, I identified DirectMemoryCRC32Digest and NativeIO classes
### Changes
* Add the open modules options to open the required module (only if jdk9+ because jdk8 doesn't know the `--add-opens` instruction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat merged pull request #3234: Enable Netty and BookKeeper IO optimizations on jdk17
Posted by GitBox <gi...@apache.org>.
merlimat merged PR #3234:
URL: https://github.com/apache/bookkeeper/pull/3234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3234: Enable Netty and BookKeeper IO optimizations on jdk17
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #3234:
URL: https://github.com/apache/bookkeeper/pull/3234#issuecomment-1105533131
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3234: Enable Netty and BookKeeper IO optimizations on jdk17
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3234:
URL: https://github.com/apache/bookkeeper/pull/3234#issuecomment-1117003694
I suggest that we'd better keep the script consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org