You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/09/26 08:41:45 UTC
[GitHub] [zeppelin] NicolasGong opened a new pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
NicolasGong opened a new pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216
[ZEPPELIN-5510] Thread leakage in JobManager of flink interpreter.
### What is this PR for?
There are some logic problems, which may lead to thread leaks.
Fix code issues.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927667422
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong commented on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
NicolasGong commented on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927261727
Ok, I'll try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong closed pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
NicolasGong closed pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4216: [ZEPPELIN-5510]There are some logic problems, which may lead to thread leaks.
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-917973530
Thanks for the contribution @NicolasGong , could you update the title to be more specific ? e.g. Thread leakage in JobManager of flink interpreter, and please check the CI, seems flink CI is failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong removed a comment on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
NicolasGong removed a comment on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927260683
> ping @NicolasGong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong removed a comment on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
NicolasGong removed a comment on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927270629
Sorry, I updated the branch code, but CI still failed. I don't know why. This problem should not be caused by the changed code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927659391
CI is passed now, thanks @NicolasGong Sometimes some tests will still fail due to network or other unknown reason, usually rerun will turn CI to green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong commented on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
NicolasGong commented on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927260683
> ping @NicolasGong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927261202
Thanks @NicolasGong Could you do rebase ? Recently we fixed flaky CI test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4216: [ZEPPELIN-5510]There are some logic problems, which may lead to thread leaks.
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927244551
ping @NicolasGong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong commented on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
NicolasGong commented on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927270629
Sorry, I updated the branch code, but CI still failed. I don't know why. This problem should not be caused by the changed code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong commented on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
NicolasGong commented on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927558996
Sorry, I rebase the code and fixed a problem. But I don't know the reason why other CI failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4216: [ZEPPELIN-5510]There are some logic problems, which may lead to thread leaks.
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-922407413
ping @NicolasGong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong removed a comment on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
NicolasGong removed a comment on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927261011
> ping @NicolasGong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong commented on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.
Posted by GitBox <gi...@apache.org>.
NicolasGong commented on pull request #4216:
URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927261011
> ping @NicolasGong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org